Fix deploy-hostpath.sh hostpath pod and CRD conditional for k8s 1.16 #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
size/XS
ggriffiths
force-pushed
the
fix_deploy_loop_for_k8s116
branch
from
96ce950
to
08b4eb0
Compare
msau42
reviewed
Apr 16, 2020
| @@ -203,7 +203,7 @@ done | |||
| # snapshotter, resizer, socat and hostpath plugin in the default namespace. | |||
| expected_running_pods=6 | |||
| cnt=0 | |||
| while [ $(kubectl get pods 2>/dev/null | grep '^csi-hostpath.* Running ' | wc -l) -lt $expected_running_pods ] || ! kubectl describe volumesnapshotclasses.snapshot.storage.k8s.io 2>/dev/null >/dev/null; do | |||
| while [ $(kubectl get pods 2>/dev/null | grep '^csi-hostpath.* Running ' | wc -l) -lt ${expected_running_pods} ]; do | |||
There was a problem hiding this comment.
Should L210 also be removed?
Signed-off-by: Grant Griffiths <grant@portworx.com>
ggriffiths
force-pushed
the
fix_deploy_loop_for_k8s116
branch
from
08b4eb0
to
c2abbda
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ggriffiths, msau42 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
TerryHowe
pushed a commit
to TerryHowe/csi-driver-host-path
that referenced
this pull request
Oct 17, 2024
…rsion Bump kind to v0.11.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Grant Griffiths grant@portworx.com
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
In kubernetes-csi/external-snapshotter#299,
deploy-hostpath is hanging due to an invalid conditional.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
n/a
Does this PR introduce a user-facing change?: