Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

master: update release-tools #311

Merged
merged 2 commits into from
May 28, 2021
Merged

master: update release-tools #311

merged 2 commits into from
May 28, 2021

Conversation

pohly
Copy link
Contributor

@pohly pohly commented May 28, 2021

Squashed 'release-tools/' changes from 71c810a..682c686

682c686a Merge pull request #162 from pohly/pod-name-via-shell-command
36a29f5c Merge pull request #163 from pohly/remove-bazel
68e43ca7 prow.sh: remove Bazel build support
c5f59c5a prow.sh: allow shell commands in CSI_PROW_SANITY_POD

git-subtree-dir: release-tools
git-subtree-split: 682c686

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 28, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 28, 2021
@pohly
Copy link
Contributor Author

pohly commented May 28, 2021

/retest

@pohly
Copy link
Contributor Author

pohly commented May 28, 2021

/hold

Let's see whether pull-kubernetes-csi-csi-driver-host-distributed-on-kubernetes-1-21 now passes.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 28, 2021
@pohly
Copy link
Contributor Author

pohly commented May 28, 2021

I'm not seeing the new CSI_PROW_SANITY_POD value in the job. Perhaps Prow needs more time to catch up with that change.

@pohly
Copy link
Contributor Author

pohly commented May 28, 2021

https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-csi_csi-driver-host-path/311/pull-kubernetes-csi-csi-driver-host-distributed-on-kubernetes-1-21/1398207884176658432 has it and seems to be passed the csi-sanity test.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 28, 2021
@xing-yang
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 28, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pohly, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a87ce83 into kubernetes-csi:master May 28, 2021
@pohly pohly deleted the prow-update-master branch July 6, 2021 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrishenzie chrishenzie Awaiting requested review from chrishenzie

@humblec humblec Awaiting requested review from humblec

Assignees

@xing-yang xing-yang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pohly @xing-yang @k8s-ci-robot