-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make driver functionality to work and adopt latest csi-lib-iscsi and csi spec 1.5.0 #70
Conversation
/release-note-none |
can you run |
That would be cool!
@andyzhangx indeed it was ran in my local setup :) and I wanted to put the fixes as followup commits 47f010f here in the PR , so marked this as WIP, once the functional verification is done I will remove the WIP. 👍
|
aha, I see, the sanity test is already running there, need to rename to |
Considering csi-lib-iscsi has good amount of fixes, it is good to consume latest commit and also good to use latest csi spec ie 1.5.0. This commit update the dependency of below projects: - github.com/container-storage-interface/spec v1.5.0 - github.com/kubernetes-csi/csi-lib-iscsi v0.0.0-20211110090527-5c802c48a124 - github.com/kubernetes-csi/csi-lib-utils v0.10.0 - google.golang.org/grpc v1.38.0 Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
59522ac
to
77d5614
Compare
|
/assign @j-griffith |
- Get rid of Multipath field from the Connector build As we have done refactoring of iscsi lib to have a multipath logic from it, while builing the connector we dont need multipath formation from the buildSCSIConnector anymore. This commit get rid of the same and leave the logic to the iscsi lib. - Add lun information to the connector builder Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: humblec, j-griffith The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/LGTM |
Considering csi-lib-iscsi has gone through some refactoring, it is
good to consume latest commit and also to use latest
csi spec ie 1.5.0.
This commit update the dependency of below projects:
The ISCSI driver functionality has been tested with this PR and it looks to be working as expected 👍
Please refer # #70 (comment)
Signed-off-by: Humble Chirammal hchiramm@redhat.com