address error return and unwanted type conversion #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this commit address unhandled error returns and also correct duplicated conversion of a type along with other linter fixes Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
approved
|
/assign @andyzhangx |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, humblec The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
andyzhangx
reviewed
Dec 9, 2021
| @@ -128,6 +128,7 @@ func (util *ISCSIUtil) DetachDisk(c iscsiDiskUnmounter, targetPath string) error | |||
| } | |||
|
|
|||
| klog.Info("successfully detached ISCSI device") | |||
|
|
|||
There was a problem hiding this comment.
nit: I think it's better remove L131 & L133 empty lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this commit address unhandled error returns and also correct
duplicated conversion of a type along with other linter fixes
Signed-off-by: Humble Chirammal hchiramm@redhat.com
-->