Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import csi-lib-iscsi to this project #76

Merged
merged 4 commits into from
Dec 13, 2021

Conversation

humblec
Copy link
Contributor

@humblec humblec commented Dec 10, 2021

Signed-off-by: Humble Chirammal hchiramm@redhat.com

What type of PR is this?

/kind feature

What this PR does / why we need it:

In our previous discussions, we have decided to archive csi-lib-iscsi project and use it directly from here.

Special notes for your reviewer:

This PR import csi-lib-iscsi to pkg/lib/iscsi dir
-->

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. labels Dec 10, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2021
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 10, 2021

CLA Signed

The committers are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 10, 2021
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Dec 10, 2021
@humblec
Copy link
Contributor Author

humblec commented Dec 10, 2021

Thought of preserving the history, but looking at the CLA complaints may be I can squash and bring those.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 10, 2021
@humblec
Copy link
Contributor Author

humblec commented Dec 10, 2021

/assign @andyzhangx

pkg/lib/iscsi/.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
pkg/lib/iscsi/CONTRIBUTING.md Outdated Show resolved Hide resolved
pkg/lib/iscsi/LICENSE Outdated Show resolved Hide resolved
pkg/lib/iscsi/go.mod Show resolved Hide resolved
@humblec
Copy link
Contributor Author

humblec commented Dec 13, 2021

Thanks @andyzhangx , ptal.. comments are addressed.

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 13, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, humblec

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f02d571 into kubernetes-csi:master Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants