-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
import csi-lib-iscsi to this project #76
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Thought of preserving the history, but looking at the CLA complaints may be I can squash and bring those. |
73486e4
to
ee1113c
Compare
git-subtree-dir: pkg/lib/iscsi git-subtree-split: 5c802c4
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
5134225
to
25b5f05
Compare
/assign @andyzhangx |
4db4b24
to
4eab6da
Compare
Thanks @andyzhangx , ptal.. comments are addressed. |
29e2929
to
6a83f70
Compare
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
6a83f70
to
9361fd9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, humblec The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Humble Chirammal hchiramm@redhat.com
What type of PR is this?
What this PR does / why we need it:
In our previous discussions, we have decided to archive csi-lib-iscsi project and use it directly from here.
Special notes for your reviewer:
This PR import csi-lib-iscsi to
pkg/lib/iscsi
dir-->