Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add details about the debugging of the driver #79

Merged
merged 1 commit into from
Dec 18, 2021
Merged

Add details about the debugging of the driver #79

merged 1 commit into from
Dec 18, 2021

Conversation

humblec
Copy link
Contributor

@humblec humblec commented Dec 17, 2021 •
edited
Loading

This commit adds details about how to debug, update and watch
logs of iscsi csi driver.

Signed-off-by: Humble Chirammal hchiramm@redhat.com

/kind documentation
-->

NONE

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Dec 17, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 17, 2021
@humblec
Copy link
Contributor Author

humblec commented Dec 17, 2021

/assign @andyzhangx

andyzhangx
andyzhangx reviewed Dec 17, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
andyzhangx
andyzhangx reviewed Dec 17, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
@humblec
Add debug doc which describe csidriver information
1b2f7a8 
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
@humblec humblec changed the title Add details about the deployment of driver Add details about the debugging of the driver Dec 17, 2021
@humblec
Copy link
Contributor Author

humblec commented Dec 17, 2021

@andyzhangx added debug doc, rest of the information I will populate in followup PRs.

andyzhangx
andyzhangx approved these changes Dec 18, 2021
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 18, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, humblec

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 21866af into kubernetes-csi:master Dec 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx andyzhangx approved these changes

@gnufied gnufied Awaiting requested review from gnufied

@jingxu97 jingxu97 Awaiting requested review from jingxu97

Assignees

@andyzhangx andyzhangx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@humblec @k8s-ci-robot @andyzhangx