Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add more unit tests #96

Closed
andyzhangx opened this issue Nov 17, 2020 · 1 comment · Fixed by #106
Closed

add more unit tests #96

andyzhangx opened this issue Nov 17, 2020 · 1 comment · Fixed by #106
Assignees
@mayankshah1607
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@andyzhangx
Copy link
Member

Is your feature request related to a problem?/Why is this needed

Describe the solution you'd like in detail

add more unit tests for https://github.com/kubernetes-csi/csi-driver-nfs/tree/master/pkg/nfs
could refer to https://github.com/kubernetes-csi/csi-driver-smb/tree/master/pkg/smb

Describe alternatives you've considered

Additional context
@andyzhangx andyzhangx added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Nov 17, 2020
@andyzhangx andyzhangx changed the title add unit tests add more unit tests Nov 17, 2020
@mayankshah1607
Copy link
Contributor

/assign

@mayankshah1607 mayankshah1607 mentioned this issue Nov 24, 2020
Merged
dobsonj pushed a commit to dobsonj/csi-driver-nfs that referenced this issue Oct 16, 2023
@openshift-merge-robot
Merge pull request kubernetes-csi#96 from shiftstack/merge-bot-master
b7393fa 
Merge https://github.com/kubernetes-csi/csi-driver-nfs:master into master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mayankshah1607 mayankshah1607

Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: Add remaining unit tests mayankshah1607/csi-driver-nfs
2 participants
@andyzhangx @mayankshah1607