-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GitHub action to be branch agnostic #228
Update GitHub action to be branch agnostic #228
Conversation
Hi @alexander-ding. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexander-ding, mauriciopoppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
What this PR does / why we need it:
Small update to the windows workflow
Which issue(s) this PR fixes:
Fixes #222
Special notes for your reviewer:
According to my understanding/reading, an event on GitHub causes a check against the .github/workflows files sitting in the branch associated with it, so we can just set
on: [push, pull_request]
. We then need to merge the changes into the v1.x branches, where the workflows should only run upon pushes/PRs targeting the v1.x branch.Does this PR introduce a user-facing change?: