-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove v1 integration tests #251
Remove v1 integration tests #251
Conversation
/cc @mauriciopoppe |
9c633df
to
8aae804
Compare
@@ -138,11 +26,6 @@ func isRunningOnGhActions() bool { | |||
return os.Getenv("CSI_PROXY_GH_ACTIONS") == "TRUE" | |||
} | |||
|
|||
// returns true if underlying os is windows | |||
func isRunningWindows() bool { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this an unused function?
@@ -1,129 +0,0 @@ | |||
#!/bin/bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
goodbye script 🥲
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexander-ding, mauriciopoppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
What this PR does / why we need it:
Remove legacy test as part of #217
Which issue(s) this PR fixes:
Fixes #249
Special notes for your reviewer:
Does this PR introduce a user-facing change?: