-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove v1 client and pkg code #252
Remove v1 client and pkg code #252
Conversation
/cc @mauriciopoppe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
@@ -23,13 +23,13 @@ lint: $(GOLANGCI_LINT) | |||
test: test-go | |||
test-go: | |||
@ echo; echo "### $@:" | |||
GO111MODULE=on go test ./pkg/... | |||
@ echo "No need to run test. Testing is done in GitHub Actions and custom Prow job." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is ok and not worth it to set additional infra for this to work given that we already have other jobs that are running the tests we want:
- integration tests are run in Prow (pull-kubernetes-csi-csi-proxy-integration)
- unit tests are run in Windows Tests / unit_tests (1.16, windows-latest) (pull_request)
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexander-ding, mauriciopoppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
What this PR does / why we need it:
Part of #217
Which issue(s) this PR fixes:
Fixes #250 Fixes #223 Fixes #224
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Deferring release note till v2 is bumped.