-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prow testing #9
Prow testing #9
Commits on Mar 15, 2019
-
build.make: avoid unit-testing E2E test suite
In repos that have a test/e2e, that test suite should be run separately because it depends on a running cluster.
Configuration menu - View commit details
-
Copy full SHA for 94fc1e3 - Browse repository at this point
Copy the full SHA 94fc1e3View commit details -
verify-shellcheck.sh: import from Kubernetes
This is an unmodified copy of kubernetes/hack/verify-shellcheck.sh revision d5a3db003916b1d33b503ccd2e4897e094d8af77.
Configuration menu - View commit details
-
Copy full SHA for fb13c51 - Browse repository at this point
Copy the full SHA fb13c51View commit details
Commits on Apr 2, 2019
-
verify-shellcheck.sh: make it usable in csi-release-tools
These are the modifications that were necessary to call this outside of Kubernetes. The support for excluding files from checking gets removed to simplify the script. It shouldn't be needed, because linting can be enabled after fixing whatever scripts might fail the check.
Configuration menu - View commit details
-
Copy full SHA for b2d25d4 - Browse repository at this point
Copy the full SHA b2d25d4View commit details -
build.make: integrate shellcheck into "make test"
By default this only tests the scripts inside the "release-tools" directory, which is useful when making experimental changes to them in a component that uses csi-release-tools. But a component can also enable checking for other directories.
Configuration menu - View commit details
-
Copy full SHA for 6c7ba1b - Browse repository at this point
Copy the full SHA 6c7ba1bView commit details -
This enables testing of other repos and of this repo itself inside Prow. Currently supported is unit testing ("make test") and E2E testing (either via a local test suite or the Kubernetes E2E test suite applied to the hostpath driver example deployment). The script passes shellcheck and uses Prow to verify that for future PRs.
Configuration menu - View commit details
-
Copy full SHA for 55212ff - Browse repository at this point
Copy the full SHA 55212ffView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a0fd49 - Browse repository at this point
Copy the full SHA 0a0fd49View commit details -
prow.sh: pull Go version from travis.yml
The travis.yml is now the only place where the Go version for the component itself needs to be configured.
Configuration menu - View commit details
-
Copy full SHA for 429581c - Browse repository at this point
Copy the full SHA 429581cView commit details
Commits on Apr 3, 2019
-
prow.sh: take Go version from Kubernetes source
Using the same (recent) Go version for all Kubernetes versions can break for older versions when there are incompatible changes in Go. To avoid that, we use exactly the minimum version of Go required for each Kubernetes version. This is based on the assumption that this combination was tested successfully. When building the E2E suite from Kubernetes (the default) we do the same, but still allow building it from elsewhere. We allow the Go version to be empty when it doesn't matter.
Configuration menu - View commit details
-
Copy full SHA for 29545bb - Browse repository at this point
Copy the full SHA 29545bbView commit details -
prow.sh: improve building Kubernetes from source
While switching back and forth between release-1.13 and release-1.14 locally, there was the problem that the local kind image kept using the wrong kubelet binary despite rebuilding from source. The problem went away after cleaning the Bazel cache. Exact root cause unknown, but perhaps using unique tags and properly cleaning the repo helps. If not, then the unique tags at least will show what the problem is.
Configuration menu - View commit details
-
Copy full SHA for 741319b - Browse repository at this point
Copy the full SHA 741319bView commit details -
prow.sh: different E2E suite depending on Kubernetes version
Instead of always using the latest E2E tests for all Kubernetes versions, the plan now is to use the tests that match the Kubernetes version. However, for 1.13 we have to make an exception because the suite for that version did not support the necessary --storage.testdriver parameter.
2Configuration menu - View commit details
-
Copy full SHA for 6602d38 - Browse repository at this point
Copy the full SHA 6602d38View commit details -
prow.sh: switch back to upstream csi-driver-host-path
The temporary fork was merged, we can use the upstream repo again.
Configuration menu - View commit details
-
Copy full SHA for d87eccb - Browse repository at this point
Copy the full SHA d87eccbView commit details