ValidateVolumeCapabilities Fails Because It Calls Non-existing Volume

[mattsmithdatera]

Reproduction:
v1.1.0 branch

func TestDriver(t *testing.T) {
	go func() {
		d := getDriver(t)
		if err := d.Run(); err != nil {
			t.Fatal(err)
		}
	}()
	sc := &sanity.Config{
		TargetPath:  "/mnt/my-publish",
		StagingPath: "/mnt/my-staging",
		Address:     Endpoint,
	}
	sanity.Test(t, sc)
}

All tests pass except ValidateVolumeCapabilities which fails for the below reason.

STEP: reusing connection to CSI driver at unix:///tmp/test-csi.sock
STEP: creating mount and staging directories
STEP: creating a single node writer volume
STEP: validating volume capabilities
cleanup: deleting sanity-controller-validate-053C02BC-18C78554 = CSI-sanity-controller-validate-053C02BC-18C78554

------------------------------
• Failure [2.087 seconds]
Controller Service
/home/ubuntu/go/src/github.com/kubernetes-csi/csi-test/pkg/sanity/tests.go:44
  ValidateVolumeCapabilities
  /home/ubuntu/go/src/github.com/kubernetes-csi/csi-test/pkg/sanity/controller.go:591
    should return appropriate values (no optional values added) [It]
    /home/ubuntu/go/src/github.com/kubernetes-csi/csi-test/pkg/sanity/controller.go:618

    Expected
        <[]*csi.VolumeCapability | len:0, cap:0>: nil
    not to be empty

    /home/ubuntu/go/src/github.com/kubernetes-csi/csi-test/pkg/sanity/controller.go:671
------------------------------
2018-12-05T18:12:46Z INFO GRPC -- request: /csi.v1.Controller/ValidateVolumeCapabilities -- volume_id:"some-vol-id" volume_capabilities:<mount:<> access_mode:<mode:SINGLE_NODE_WRITER > > 

You can see that the volume created for this test was sanity-controller-validate-053C02BC-18C78554, but the volume called for the test in the ValidateVolumeCapabilities step is some-vol-id.

For some reason, the original volume-id isn't being used during subsequent steps of the test. My ValidateVolumeCapabilities function is returning an error because the volume_id is invalid.

[pohly]

Just to clarify, this happens because your ValidateVolumeCapabilities checks for a valid volume ID?

I agree, the test should be using a valid volume. Care to submit a PR which fixes that? If so, please do it against master, it can and will be backported.

[mattsmithdatera]

ValidateVolumeCapabilities checks for a non-existing volume ID. The create volume call in the test creates CSI volume: sanity-controller-validate-053C02BC-18C78554, but the validate volume call isn't looking for that volume, instead it's looking for volume: some-vol-id which was never created.