Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strict staging and target directory #182

Merged
merged 1 commit into from
Mar 25, 2019

Commits on Mar 21, 2019

  1. strict staging and target directory

    The CSI spec requires the CO (= csi-sanity) to create the staging
    directory and the *parent* of the target
    directory. Kubernetes (kubernetes/kubernetes#75535)
    and csi-sanity have handled the target directory incorrectly by
    creating it.
    
    Now directory handling is standard-compliant and more strict, to catch
    mistakes:
    - the specified target directory is treated as the parent which gets
      created by csi-sanity, while the actual NodePublishVolume call then
      specifies an entry inside that directory; this was done to keep the
      code simple (handling both directories is the same) and to minimize
      API changes
    - os.Mkdir and os.Remove are used instead of the more forgiving
      os.MkdirAll and os.RemoveAll; as a result, both directories
      now must be different (which is what they should have been in the
      anyway, it just happened to work when they were identical)
    - the mock driver checks for non-existence of the target directory
    pohly committed Mar 21, 2019
    Configuration menu
    Copy the full SHA
    267dbbc View commit details
    Browse the repository at this point in the history