prow testing #184
Merged
prow testing #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If for whatever reasons a repo already had a `release-tools` directory before doing a clean import of it with `git subtree`, the check used to fail because it found those old commits. This can be fixed by telling `git log` to stop when the directory disappears from the repo. There has to be a commit with removes the old content, because otherwise `git subtree add` doesn't work. Fixes: kubernetes-csi/external-resizer#21
verify-subtree.sh: relax check and ignore old content
In repos that have a test/e2e, that test suite should be run separately because it depends on a running cluster.
This is an unmodified copy of kubernetes/hack/verify-shellcheck.sh revision d5a3db003916b1d33b503ccd2e4897e094d8af77.
k8s-ci-robot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pohly The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
/test pull-sig-storage-csi-test-kubernetes-master |
|
/test pull-sig-storage-csi-test-kubernetes-master |
|
/test pull-sig-storage-csi-test-kubernetes-master |
pohly
force-pushed
the
prow
branch
2 times, most recently
from
0516917
to
3e9b289
Compare
|
/test pull-sig-storage-csi-test-kubernetes-master |
|
/test pull-sig-storage-csi-test-kubernetes-master |
|
/test pull-sig-storage-csi-test-kubernetes-master |
|
/test pull-sig-storage-csi-test-kubernetes-master |
|
/test pull-sig-storage-csi-test-kubernetes-master |
|
/test pull-sig-storage-csi-test-kubernetes-master |
These are the modifications that were necessary to call this outside of Kubernetes. The support for excluding files from checking gets removed to simplify the script. It shouldn't be needed, because linting can be enabled after fixing whatever scripts might fail the check.
By default this only tests the scripts inside the "release-tools" directory, which is useful when making experimental changes to them in a component that uses csi-release-tools. But a component can also enable checking for other directories.
This enables testing of other repos and of this repo itself inside
Prow. Currently supported is unit testing ("make test") and E2E
testing (either via a local test suite or the Kubernetes E2E test
suite applied to the hostpath driver example deployment).
The script passes shellcheck and uses Prow to verify that for future
PRs.
The travis.yml is now the only place where the Go version for the component itself needs to be configured.
Using the same (recent) Go version for all Kubernetes versions can break for older versions when there are incompatible changes in Go. To avoid that, we use exactly the minimum version of Go required for each Kubernetes version. This is based on the assumption that this combination was tested successfully. When building the E2E suite from Kubernetes (the default) we do the same, but still allow building it from elsewhere. We allow the Go version to be empty when it doesn't matter.
While switching back and forth between release-1.13 and release-1.14 locally, there was the problem that the local kind image kept using the wrong kubelet binary despite rebuilding from source. The problem went away after cleaning the Bazel cache. Exact root cause unknown, but perhaps using unique tags and properly cleaning the repo helps. If not, then the unique tags at least will show what the problem is.
Instead of always using the latest E2E tests for all Kubernetes versions, the plan now is to use the tests that match the Kubernetes version. However, for 1.13 we have to make an exception because the suite for that version did not support the necessary --storage.testdriver parameter.
|
/test pull-sig-storage-csi-test-kubernetes-master |
The temporary fork was merged, we can use the upstream repo again.
|
/test pull-sig-storage-csi-test-kubernetes-master |
|
/test pull-sig-storage-csi-test-kubernetes-master |
|
/test pull-sig-storage-csi-test |
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
@msau42 if the test succeeds, then please merge. This is up-to-date with kubernetes-csi/csi-release-tools#9 (= d87eccb). |
For csi-test, we need to lock down testing onto a driver that is known to pass. Testing different versions of the driver with csi-sanity is done in the csi-driver-host-path repo.
|
pull-sig-storage-csi-test was failing because it was still using the v1.0.1 driver, which (in contrast to the current one) doesn't pass csi-sanity. Should be fixed by bd1c839 . /test pull-sig-storage-csi-test |
|
@msau42 yep, ready for merging. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
suneeth51
pushed a commit
to suneeth51/csi-test
that referenced
this pull request
Sep 11, 2019
prow testing
stmcginnis
pushed a commit
to stmcginnis/csi-test
that referenced
this pull request
Oct 9, 2024
…ubleshooting SIDECAR_RELEASE_PROCESS.md: add troubleshooting for image publishing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.