Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the cert-manager csi-drivers #591

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Add the cert-manager csi-drivers #591

merged 1 commit into from
Apr 4, 2024

Conversation

SgtCoDFish
Copy link
Contributor

@SgtCoDFish SgtCoDFish commented Mar 27, 2024 •
edited
Loading

The cert-manager project has been maintaining two CSI drivers for years at this point. I spotted the drivers page of these docs today after releasing cert-manager csi-driver v0.8.0 and it seems like we'd make a good addition to this list!

I know for a fact that both of these CSI drivers are used in production at multiple companies.

We actually also maintain a csi-lib library to help others build CSI drivers which issue certificates with cert-manager.

Happy to rework / reword this if needed 😁

Adds driver entries for cert-manager csi-driver and cert-manager csi-driver-spiffe

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 27, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @SgtCoDFish!

It looks like this is your first PR to kubernetes-csi/docs 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/docs has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 27, 2024
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 27, 2024
@SgtCoDFish SgtCoDFish force-pushed the cert-manager-csi-drivers branch from c1b18a1 to 1226519 Compare March 27, 2024 17:06
xing-yang
xing-yang reviewed Apr 4, 2024
View reviewed changes
book/src/drivers.md Outdated Show resolved Hide resolved
book/src/drivers.md Outdated Show resolved Hide resolved
@SgtCoDFish SgtCoDFish force-pushed the cert-manager-csi-drivers branch from 1226519 to a05389a Compare April 4, 2024 14:08
xing-yang
xing-yang reviewed Apr 4, 2024
View reviewed changes
book/src/drivers.md Outdated Show resolved Hide resolved
@SgtCoDFish
add the cert-manager csi-drivers
1191715 
Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
@SgtCoDFish SgtCoDFish force-pushed the cert-manager-csi-drivers branch from a05389a to 1191715 Compare April 4, 2024 14:32
@xing-yang
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 4, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SgtCoDFish, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2024
@k8s-ci-robot k8s-ci-robot merged commit f108b84 into kubernetes-csi:master Apr 4, 2024
3 checks passed
@SgtCoDFish SgtCoDFish deleted the cert-manager-csi-drivers branch April 4, 2024 14:51
@SgtCoDFish
Copy link
Contributor Author

Thanks very much @xing-yang 🚀 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xing-yang xing-yang xing-yang left review comments

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@xing-yang xing-yang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SgtCoDFish @k8s-ci-robot @xing-yang