Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Docs for external-snapshot-metadata sidecar container #601

Conversation

PrasadG193
Copy link

This PR is a placeholder for adding documentation for external-snapshot-metadata sidecar container.
This new sidecar container will be added as a part of enhancement kubernetes/enhancements#3314
KEP: kubernetes/enhancements#4082
Git repo: https://github.com/kubernetes-csi/external-snapshot-metadata

Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
@k8s-ci-robot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 27, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: PrasadG193
Once this PR has been reviewed and has the lgtm label, please assign msau42 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 27, 2024
@Princesso
Copy link

Hi @PrasadG193, this PR should target dev-1.31. Please follow the steps here to open a PR against dev-1.31 branch in the k/website repo.

@PrasadG193
Copy link
Author

@Princesso we don't need changes in the website repo for the enhancement.

@Princesso
Copy link

Hi @PrasadG193 thanks for the update. I have just gotten confirmation from the release lead, that we need to track this as a doc PR. I'll be following up shortly. Thank you!

@MaryamTavakkoli
Copy link

Hello @PrasadG193 👋 please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday July 16th 2024 18:00 PST. Thank you!

@Princesso
Copy link

Hi @PrasadG193, a gentle reminder that tomorrow is the deadline for having your Docs PR ready for review. Please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before tomorrow, Tuesday, July 16th, 2024 18:00 PST.

@PrasadG193
Copy link
Author

Folks, the feature implementation is not complete yet, so we didn't start on documentation.

@drewhagen
Copy link

drewhagen commented Jul 17, 2024

Hello @PrasadG193! Thanks for pointing this out.
It's true that Docs PR Ready for Review is usually after Code Freeze. However, the Code Freeze deadline has been moved back for the 1.31 release. See the schedule here: https://www.kubernetes.dev/resources/release/

Docs PR Ready for Review deadline remains yesterday July 16th. This is to allow time before Docs Freeze on Tuesday 30th July 2024, after which will require an exception for this feature to ship with 1.31 if docs aren't merged. Docs Freeze remains July 30th since there is other work needed from then leading up to the release. And SIG Docs and a tech lead will need as much of this time before Docs Freeze as possible to review, give feedback, see iterated changes, then ultimately approve and merge these docs among many others.

Can you make some progress on these docs concurrent to your feature so that we can start the review process? This will move the needle towards quality docs for Kubernetes users. We really appreciate it, thanks!

@MaryamTavakkoli
Copy link

Hello @PrasadG193👋! I'm reaching out from the Docs team. Just checking in as we approach Docs Freeze on Tuesday July 30th 18:00 PDT. This documentation appears to still be under review. To meet the Docs Freeze, this PR must have a technical review as well as lgtm and approve labels applied, without any unaddressed comments or concerns from SIG Docs. The status of this enhancement is marked as at risk for docs freeze. Thank you!

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 21, 2024
@PrasadG193
Copy link
Author

Closing this w.r.t #605

@PrasadG193 PrasadG193 closed this Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants