Update CSINodeInfo

[jsafrane]

Kubernetes 1.13 introduced CSINodeInfo.Spec + Status. Fix the code and vendor kubernetes 1.13.0-beta2.

Fixes: #99

@xing-yang, I fixed your PR to vendor the right code from the right places (I think :-).

[xing-yang]

Thanks @jsafrane ! I'll give this PR a try.

[xing-yang]

I tested this PR with and without enabling CSINodeInfo, but I still got the error:

external-attacher logs:

I1126 20:03:33.457293 1 csi_handler.go:524] Can't get CSINodeInfo 127.0.0.1: csinodeinfos.csi.storage.k8s.io "127.0.0.1" not found
I1126 20:03:33.457309 1 csi_handler.go:388] Saving attach error to "csi-cc697e353e2d1b67f03d4c6e37d7f7c04480c3126d12b036e1e29c3517bd0512"
I1126 20:03:33.459175 1 csi_handler.go:398] Saved attach error to "csi-cc697e353e2d1b67f03d4c6e37d7f7c04480c3126d12b036e1e29c3517bd0512"
I1126 20:03:33.459194 1 csi_handler.go:103] Error processing "csi-cc697e353e2d1b67f03d4c6e37d7f7c04480c3126d12b036e1e29c3517bd0512": failed to attach: node "127.0.0.1" has no NodeID annotation

driver-registrar logs:

I1126 20:00:30.487440 1 connection.go:136] GRPC call: /csi.v1.Node/NodeGetInfo
I1126 20:00:30.487454 1 connection.go:137] GRPC request:
I1126 20:00:30.495795 1 connection.go:139] GRPC response: node_id:"ubuntu,iqn:iqn.1993-08.org.debian:01:c6961059376e"
I1126 20:00:30.496273 1 connection.go:140] GRPC error:
I1126 20:00:30.496526 1 node_register.go:63] CSI driver node ID: "ubuntu,iqn:iqn.1993-08.org.debian:01:c6961059376e"
I1126 20:00:30.497795 1 node_register.go:86] Starting Registration Server at: /registration/csi-opensdsplugin-reg.sock
I1126 20:00:30.499127 1 node_register.go:93] Registration Server started at: /registration/csi-opensdsplugin-reg.sock

[davidz627]

@xing-yang are you using the new plugin registration dir?
https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/blob/master/deploy/kubernetes/base/node.yaml#L64
path: /var/lib/kubelet/plugins_registry/
as opposed to the old: path: /var/lib/kubelet/plugins

[xing-yang]

Yes. Actually I realized I have been testing using K8S v1.13.0-beta.1 so my tests are invalid. I need to re-test using beta.2.

[xing-yang]

Tested with CSINodeInfo enabled using K8S v1.13.0-beta.2. It works!
Will test without CSINodeInfo next.

[xing-yang]

Tested without CSINodeInfo using K8S v1.13.0-beta.2. It works as well!

[xing-yang]

LGTM

[saad-ali]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, saad-ali

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jsafrane,saad-ali]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[davidz627]

kubernetes-retired/kubernetes-csi-migration-library#9

[saad-ali]

Let's cherry pick this to release-1.0 branch

[jsafrane]

Picked in #103