Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ControllerPublishSecrets #38

Merged
merged 1 commit into from
Apr 3, 2018

Conversation

jsafrane
Copy link
Contributor

@jsafrane jsafrane commented Mar 15, 2018

Pass secrets from secretRef in PV to Attach and Detach calls.

Fixes: #32

@sbezverk
Copy link
Contributor

@jsafrane @saad-ali This PR uses PV's ControllerPublishSecretRef to pass it to the attacher, but the question is who and how ControllerPublishSecretRef can be set? PV object gets created by a provisioner and the only secret available to the provisioner is the one from the StorageClass and it is for Create/Delete Volume. Should we extend StorageClass to carry all possible secrets, so the provisioner at the time of creating PV could populate those secrets? Other secrets are: (NodeStageSecretRef, NodePublishSecretRef)

@jsafrane
Copy link
Contributor Author

@sbezverk, that's what I asked on the meeting on Monday and the agreement is that "cluster admin must set [them] manually". In the next release we may think about something better.

@sbezverk
Copy link
Contributor

@jsafrane right, I was trying to point out that the cluster admin at the moment can setup only ONLY 1 secret via StorageClass. For sure further steps are required to change that..

@saad-ali
Copy link
Member

/lgtm
/approve

Needs rebase

@jsafrane jsafrane merged commit 27299be into kubernetes-csi:master Apr 3, 2018
jsafrane pushed a commit to jsafrane/external-attacher that referenced this pull request Jun 15, 2022
…cy-openshift-4.11-csi-attacher

Updating csi-attacher images to be consistent with ART
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants