Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"ControllerGetVolume" reports "Not Found" is invalid with local storage backend #99

Closed
zhucan opened this issue Nov 15, 2021 · 9 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@zhucan
Copy link
Member

zhucan commented Nov 15, 2021

Reproduce:

  1. deploy the external-provisioner in election-leader mode and with replicatins >=2.
  2. disable "ControllerListVolume" capability in hostpath driver.
  3. deploy the hostpath driver in daemonset.
  4. use "ControllerGetVolume" to get volume'status.
  5. deploy the healthe monitor sidecar with election-leader mode.
  6. create pvc in the local.

Fix:

  1. if the backend storage is local, we should filter the pv with node name. Only monitor the pv in the same node with the sidecar

Suggestion:

  1. If backend storege is local disk, Not only "COntrollerGetVolume" or "ControllerListVolume" should monitor the local volume that with the monitor sidecar in the same node.

CC @xing-yang

@xing-yang
Copy link
Contributor

xing-yang commented Nov 16, 2021

@zhucan How many worker nodes have you deployed?
I don't understand your suggestion. Can you answer the following questions?

  • If backend storage is local disk, does "ControllerGetVolume" work?
  • If backend storage is local disk, does "ListVolumes" work?

@zhucan
Copy link
Member Author

zhucan commented Nov 16, 2021

@xing-yang If only "ControllerGetVolume" enabled, It will get the pv firstly and "GetVolume" from the local disk, but if the volume not exist in the local node(in the other node), it will reports the volume is "Not Found". But the reports is invalid.

@xing-yang
Copy link
Contributor

There's another issue opened to track this and there's already an WIP PR about it.
#87

@xing-yang
Copy link
Contributor

Hi @pohly, do you know if distributed external-provisioner works with CSI hostpath driver? Do we have e2e tests for distributed mode using CSI hostpath driver?

@pohly
Copy link
Contributor

pohly commented Nov 16, 2021

Yes, it works.

There is a separate deployment and a Prow job which uses that deployment.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 14, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 16, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

5 participants