Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: kind update 0.10 test #591

Closed
wants to merge 2 commits into from
Closed

WIP: kind update 0.10 test #591

wants to merge 2 commits into from

Conversation

pohly
Copy link
Contributor

@pohly pohly commented Mar 22, 2021

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

Test PR for kubernetes-csi/csi-release-tools#138, do not merge.

@k8s-ci-robot
Copy link
Contributor

@pohly: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 22, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 22, 2021
@pohly
Copy link
Contributor Author

pohly commented Mar 23, 2021

/test pull-kubernetes-csi-external-provisioner-distributed-on-kubernetes-master

@pohly
Copy link
Contributor Author

pohly commented Mar 24, 2021

With KinD 0.10.0, bringing up a cluster for Kubernetes master fails: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-csi_external-provisioner/591/pull-kubernetes-csi-external-provisioner-distributed-on-kubernetes-master/1374470089780236288

Somehow that does not happen with KinD 0.9.0, but that's just a strange coincidence. Ben wasn't sure why. In general, only KinD master is (eventually) guaranteed to work with Kubernetes master.

@pohly
Squashed 'release-tools/' changes from 95eac3362..1c0fb096c
62d0ed3 
1c0fb096c prow.sh: use KinD main for latest Kubernetes
1d77cfcbf Merge pull request kubernetes-csi#138 from pohly/kind-update-0.10
bff2fb7eb prow.sh: KinD 0.10.0

git-subtree-dir: release-tools
git-subtree-split: 1c0fb096ccff59b9ebb39a4d7059dbfaa89c3ad0
@pohly
Merge commit '62d0ed30916edf07599e9f309fbd9ff0f5e6b1fb' into kind-upd…
4ea78a9 
…ate-0.10-test
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 24, 2021
@pohly
Copy link
Contributor Author

pohly commented Mar 24, 2021

/test pull-kubernetes-csi-external-provisioner-distributed-on-kubernetes-master

@k8s-ci-robot
Copy link
Contributor

@pohly: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-csi-external-provisioner-distributed-on-kubernetes-master 4ea78a9 link /test pull-kubernetes-csi-external-provisioner-distributed-on-kubernetes-master

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pohly
Copy link
Contributor Author

pohly commented Mar 24, 2021

With PR kubernetes-csi/csi-release-tools#139, bringing up the cluster works again: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-csi_external-provisioner/591/pull-kubernetes-csi-external-provisioner-distributed-on-kubernetes-master/1374641423768358912

@pohly pohly closed this Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 Awaiting requested review from msau42

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pohly @k8s-ci-robot