-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add groupName in doc.go when generating files #123
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@msau42 @j-griffith PTAL. Thanks. |
Is this a breaking change? Do we need a release note? |
There is no API change here, so I initially thought release note is not needed. However, if someone uses informers and clientset of volumesnapshot directly, they will have to change their code. So let me add a release note for that. |
Also the group name is changing right? |
The group name is only changed for the fake object which can be used for testing (to make sure they are in-sync with the real group name). The group name for the real VolumeSnapshot object remains the same. To my surprise, this also changes "VolumeSnapshot" to "Snapshot" when referencing the objects in the clientset and informers. |
/lgtm |
…ncy-openshift-4.15-ose-csi-external-snapshotter OCPBUGS-24338: Updating ose-csi-external-snapshotter-container image to be consistent with ART
What type of PR is this?
/kind bug
What this PR does / why we need it:
Adds groupName in doc.go when generating files so that the fake volumesnapshot has the correct groupName.
Which issue(s) this PR fixes:
Fixes #112
Special notes for your reviewer:
Does this PR introduce a user-facing change?: