Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add groupName in doc.go when generating files #123

Merged
merged 1 commit into from
May 10, 2019

Conversation

xing-yang
Copy link
Collaborator

@xing-yang xing-yang commented May 9, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
Adds groupName in doc.go when generating files so that the fake volumesnapshot has the correct groupName.

Which issue(s) this PR fixes:
Fixes #112

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Changes the API group name for the fake VolumeSnapshot object to "snapshot.storage.k8s.io" to be in-sync with the group name of the real VolumeSnapshot object. As a result, the generated interfaces for clientset and informers of VolumeSnapshot are also changed from "VolumeSnapshot" to "Snapshot".

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. labels May 9, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 9, 2019
@xing-yang
Copy link
Collaborator Author

/retest

@xing-yang xing-yang requested a review from msau42 May 10, 2019 17:36
@xing-yang
Copy link
Collaborator Author

@msau42 @j-griffith PTAL. Thanks.

@msau42
Copy link
Collaborator

msau42 commented May 10, 2019

Is this a breaking change? Do we need a release note?

@xing-yang
Copy link
Collaborator Author

There is no API change here, so I initially thought release note is not needed. However, if someone uses informers and clientset of volumesnapshot directly, they will have to change their code. So let me add a release note for that.

@msau42
Copy link
Collaborator

msau42 commented May 10, 2019

Also the group name is changing right?

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels May 10, 2019
@xing-yang
Copy link
Collaborator Author

The group name is only changed for the fake object which can be used for testing (to make sure they are in-sync with the real group name). The group name for the real VolumeSnapshot object remains the same. To my surprise, this also changes "VolumeSnapshot" to "Snapshot" when referencing the objects in the clientset and informers.

@j-griffith
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 10, 2019
@k8s-ci-robot k8s-ci-robot merged commit 567d14c into kubernetes-csi:master May 10, 2019
dobsonj pushed a commit to dobsonj/external-snapshotter that referenced this pull request Dec 13, 2023
…ncy-openshift-4.15-ose-csi-external-snapshotter

OCPBUGS-24338: Updating ose-csi-external-snapshotter-container image to be consistent with ART
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing 'groupName' comment in doc.go - wrong group for fake objects
4 participants