add support to configure logging format #129

aramase · 2020-12-14T18:25:36Z

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind feature

What this PR does / why we need it:
Adds configuration for json log formatter

Which issue(s) this PR fixes:

Fixes #128

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

added --logging-format to set log formatter (default: text)

k8s-ci-robot · 2020-12-14T18:25:43Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aramase
To complete the pull request process, please assign msau42 after the PR has been reviewed.
You can assign the PR to them by writing /assign @msau42 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2020-12-14T18:25:44Z

Welcome @aramase!

It looks like this is your first PR to kubernetes-csi/node-driver-registrar 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/node-driver-registrar has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2020-12-14T18:25:45Z

Hi @aramase. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Jiawei0227 · 2020-12-14T22:39:08Z

/ok-to-test

aramase · 2020-12-15T07:56:46Z

/retest

Jiawei0227 · 2020-12-15T18:57:11Z

Hey @aramase , can you help to rebase and update the dependency to 0.20? Thanks a lot!

aramase · 2020-12-15T19:09:49Z

Hey @aramase , can you help to rebase and update the dependency to 0.20? Thanks a lot!

@Jiawei0227 for sure!

Jiawei0227 · 2020-12-15T19:48:55Z

/lgtm
Thanks for the contribution!
/assign @msau42 for the final approval.

Jiawei0227 · 2020-12-15T19:49:26Z

/assign @msau42

msau42 · 2020-12-15T21:26:06Z

cmd/csi-node-driver-registrar/main.go

@@ -53,6 +54,7 @@ var (
 	healthzPort             = flag.Int("health-port", 0, "(deprecated) TCP port for healthz requests. Set to 0 to disable the healthz server. Only one of `--health-port` and `--http-endpoint` can be set.")
 	httpEndpoint            = flag.String("http-endpoint", "", "The TCP network address where the HTTP server for diagnostics, including the health check indicating whether the registration socket exists, will listen (example: `:8080`). The default is empty string, which means the server is disabled. Only one of `--health-port` and `--http-endpoint` can be set.")
 	showVersion             = flag.Bool("version", false, "Show version.")
+	logFormatJSON           = flag.Bool("log-format-json", false, "set log formatter to json")


It looks like component base already supports a log format flag, so I'm not sure we need to explicitly add one here:

https://github.com/kubernetes/component-base/blob/master/logs/options.go#L89

I think it would be better if we switch to component-base log pkg instead of using klog directly.

sure, let me do that.

Updated, PTAL!

k8s-ci-robot · 2020-12-15T21:48:45Z

New changes are detected. LGTM label has been removed.

pierluigilenoci · 2021-02-11T11:18:10Z

@aramase could you please fix the conflict?

pierluigilenoci · 2021-02-19T09:34:06Z

@aramase any feedback from the community?
Ref: kubernetes-sigs/secrets-store-csi-driver#442 (comment)

msau42 · 2021-03-31T01:19:31Z

Revisiting this again. Now that Kubernetes has introduced structured logging, do we still want the changes here, or do we want to consider following what Kubernetes is doing?

aramase · 2021-03-31T06:33:52Z

Revisiting this again. Now that Kubernetes has introduced structured logging, do we still want the changes here, or do we want to consider following what Kubernetes is doing?

Even with structured logging we would need to support the json log format so I think we would still need this PR. I can help with using structured logging in a separate PR for the node-driver-registrar, liveness-probe and dust off this PR for review again. Let me know.

fejta-bot · 2021-06-29T07:06:22Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

pierluigilenoci · 2021-06-29T07:22:47Z

/remove-lifecycle stale

k8s-triage-robot · 2021-09-27T07:44:23Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

pierluigilenoci · 2021-09-27T09:50:32Z

/remove-lifecycle stale

k8s-triage-robot · 2021-12-26T10:17:15Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

pierluigilenoci · 2022-01-03T16:59:25Z

/remove-lifecycle stale

k8s-triage-robot · 2022-04-03T17:39:30Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

pierluigilenoci · 2022-04-04T07:54:02Z

/remove-lifecycle stale

pierluigilenoci · 2022-04-04T07:54:25Z

@aramase any feedback from the community?
Ref: kubernetes-sigs/secrets-store-csi-driver#442 (comment)

aramase · 2022-04-04T07:59:00Z

@aramase any feedback from the community?
Ref: kubernetes-sigs/secrets-store-csi-driver#442 (comment)

@pierluigilenoci There has been some discussion on the PRs. I will let the maintainers of the node-driver-registrar and liveness probe decide how they want to proceed with supporting json log formatting. I don't have the time currently for rebasing the 2 PRs, so I'm going to close them and let someone else pick up the issue if there is interest in supporting the json log format.

/close

k8s-ci-robot · 2022-04-04T07:59:03Z

@aramase: Closed this PR.

In response to this:

@aramase any feedback from the community?
Ref: kubernetes-sigs/secrets-store-csi-driver#442 (comment)

@pierluigilenoci There has been some discussion on the PRs. I will let the maintainers of the node-driver-registrar and liveness probe decide how they want to proceed with supporting json log formatting. I don't have the time currently for rebasing the 2 PRs, so I'm going to close them and let someone else pick up the issue if there is interest in supporting the json log format.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pohly · 2022-04-04T08:30:41Z

Work in this area will be tracked via this project board: https://github.com/orgs/kubernetes-csi/projects/46

k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 14, 2020

k8s-ci-robot requested review from davidz627 and msau42 December 14, 2020 18:25

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 14, 2020

k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 14, 2020

aramase mentioned this pull request Dec 14, 2020

Support logFormatJSON for node-driver-registrar & liveness-probe Azure/secrets-store-csi-driver-provider-azure#338

Closed

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 14, 2020

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 15, 2020

aramase force-pushed the logformatjson branch from f3a65c5 to b3d0775 Compare December 15, 2020 19:12

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 15, 2020

aramase force-pushed the logformatjson branch from b3d0775 to 4e63cf4 Compare December 15, 2020 19:13

k8s-ci-robot assigned Jiawei0227 Dec 15, 2020

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 15, 2020

k8s-ci-robot assigned msau42 Dec 15, 2020

msau42 reviewed Dec 15, 2020

View reviewed changes

aramase force-pushed the logformatjson branch from 4e63cf4 to 715c866 Compare December 15, 2020 21:48

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 15, 2020

pohly mentioned this pull request Feb 3, 2021

master: update release-tools #134

Merged

aramase mentioned this pull request Feb 11, 2021

Problems with log configurations kubernetes-sigs/secrets-store-csi-driver#442

Closed

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 29, 2021

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 29, 2021

aramase mentioned this pull request Aug 17, 2021

add support to configure logging format kubernetes-csi/livenessprobe#98

Closed

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 27, 2021

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 27, 2021

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 26, 2021

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 3, 2022

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 3, 2022

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 4, 2022

k8s-ci-robot closed this Apr 4, 2022

aramase deleted the logformatjson branch April 4, 2022 07:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add support to configure logging format #129

add support to configure logging format #129

aramase commented Dec 14, 2020 •

edited

Loading

k8s-ci-robot commented Dec 14, 2020

k8s-ci-robot commented Dec 14, 2020

k8s-ci-robot commented Dec 14, 2020

Jiawei0227 commented Dec 14, 2020

aramase commented Dec 15, 2020

Jiawei0227 commented Dec 15, 2020

aramase commented Dec 15, 2020

Jiawei0227 commented Dec 15, 2020

Jiawei0227 commented Dec 15, 2020

msau42 Dec 15, 2020

aramase Dec 15, 2020

aramase Dec 16, 2020

k8s-ci-robot commented Dec 15, 2020

pierluigilenoci commented Feb 11, 2021

pierluigilenoci commented Feb 19, 2021

msau42 commented Mar 31, 2021

aramase commented Mar 31, 2021

fejta-bot commented Jun 29, 2021

pierluigilenoci commented Jun 29, 2021

k8s-triage-robot commented Sep 27, 2021

pierluigilenoci commented Sep 27, 2021

k8s-triage-robot commented Dec 26, 2021

pierluigilenoci commented Jan 3, 2022

k8s-triage-robot commented Apr 3, 2022

pierluigilenoci commented Apr 4, 2022

pierluigilenoci commented Apr 4, 2022

aramase commented Apr 4, 2022

k8s-ci-robot commented Apr 4, 2022

pohly commented Apr 4, 2022

add support to configure logging format #129

add support to configure logging format #129

Conversation

aramase commented Dec 14, 2020 • edited Loading

k8s-ci-robot commented Dec 14, 2020

k8s-ci-robot commented Dec 14, 2020

k8s-ci-robot commented Dec 14, 2020

Jiawei0227 commented Dec 14, 2020

aramase commented Dec 15, 2020

Jiawei0227 commented Dec 15, 2020

aramase commented Dec 15, 2020

Jiawei0227 commented Dec 15, 2020

Jiawei0227 commented Dec 15, 2020

msau42 Dec 15, 2020

Choose a reason for hiding this comment

aramase Dec 15, 2020

Choose a reason for hiding this comment

aramase Dec 16, 2020

Choose a reason for hiding this comment

k8s-ci-robot commented Dec 15, 2020

pierluigilenoci commented Feb 11, 2021

pierluigilenoci commented Feb 19, 2021

msau42 commented Mar 31, 2021

aramase commented Mar 31, 2021

fejta-bot commented Jun 29, 2021

pierluigilenoci commented Jun 29, 2021

k8s-triage-robot commented Sep 27, 2021

pierluigilenoci commented Sep 27, 2021

k8s-triage-robot commented Dec 26, 2021

pierluigilenoci commented Jan 3, 2022

k8s-triage-robot commented Apr 3, 2022

pierluigilenoci commented Apr 4, 2022

pierluigilenoci commented Apr 4, 2022

aramase commented Apr 4, 2022

k8s-ci-robot commented Apr 4, 2022

pohly commented Apr 4, 2022

aramase commented Dec 14, 2020 •

edited

Loading