This repository has been archived by the owner on Jul 30, 2021. It is now read-only.
Add /lib/modules mount to kube-proxy #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/XS
|
lgtm |
|
I don't think we need this - the kernel modules should be automatically loaded. |
|
Oh nm see the linked issue. This is unfortunate. Can we at least set it to read-only? |
|
Yeah, we can set it read-only. I linked to the upstream patch that does the same. The patch adding modprobe back into the image wasn't picked for v1.8.2 so the log warning will still be present. kubernetes/kubernetes#54325 Wait on v1.8.3. |
k8s-ci-robot
added
size/S
This was referenced Nov 8, 2017
|
Rebased on #765 for Kubernetes v1.8.3 |
rphillips
approved these changes
Nov 8, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wait for Kubernetes v1.8.3 and test that this addresses the warning log in #741. This paves the way to use
ip_vsin kube-proxy in future, but does not enable it for now.rel: kubernetes/kubernetes#17470, kubernetes/kubernetes#52003
Closes #741