This repository has been archived by the owner on Jul 30, 2021. It is now read-only.
checkpoint: only watch pods in kube-system #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/S
diegs
approved these changes
Nov 15, 2017
|
coreosbot run e2e checkpointer |
|
Will remove the flag after the CI run. Wanted to keep the dream of the checkpointer being usable by other components. |
ericchiang
changed the title
k8s-ci-robot
added
size/XS
|
coreosbot run e2e checkpointer |
diegs
approved these changes
Nov 16, 2017
|
coreosbot run e2e |
dghubble
approved these changes
Nov 17, 2017
diegs
pushed a commit
to diegs/bootkube
that referenced
this pull request
Dec 5, 2017
The checkpointer now only watches pods in kube-system (kubernetes-retired#774), so it doesn't need cluster wide permissions.
diegs
pushed a commit
to diegs/bootkube
that referenced
this pull request
Dec 7, 2017
The checkpointer now only watches pods in kube-system (kubernetes-retired#774), so it doesn't need cluster wide permissions.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is so we can drop the checkpoint's ClusterRole to a Role. See discussion #767 (review)