Skip to content
This repository has been archived by the owner on Jul 30, 2021. It is now read-only.

pkg/asset: Add flannel service account and RBAC #869

Merged
merged 1 commit into from
Feb 1, 2018
Merged

pkg/asset: Add flannel service account and RBAC #869

merged 1 commit into from
Feb 1, 2018

Conversation

dghubble
Copy link
Contributor

@dghubble dghubble commented Jan 29, 2018

  • Define a limited ClusterRole and service account for flannel. Before this change, flannel technically had access to whatever the kube-system default service account did.
  • Drop the weird "kube-" prefix on flannel assets. We don't do this for other assets.

The ClusterRole is provided by upstream so I figured we should make use of it.

* Define a limited ClusterRole and service account for
flannel
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 29, 2018
@rphillips
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2018
@ericchiang ericchiang merged commit d900dd8 into kubernetes-retired:master Feb 1, 2018
@dghubble dghubble deleted the flannel-rbac branch February 3, 2018 04:35
dghubble added a commit to poseidon/terraform-render-bootstrap that referenced this pull request Feb 3, 2018
* Define a limited ClusterRole and service account for flannel
* kubernetes-retired/bootkube#869
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants