Skip to content
This repository has been archived by the owner on Jul 30, 2021. It is now read-only.

update Kubernetes dependencies to 1.9.3 #895

Closed
wants to merge 2 commits into from
Closed

update Kubernetes dependencies to 1.9.3 #895

wants to merge 2 commits into from

Conversation

ericchiang
Copy link
Contributor

@ericchiang ericchiang commented Feb 15, 2018

We badly need to stop importing kubectl. It's much less regimented about what we import and is really bloating our transitive dependencies.

closes #833

cc @rphillips @colemickens

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 15, 2018

[[override]]
name = "cloud.google.com/go"
revision = "3b1ae45394a234c385be014e9a488f2bb6eef821"
[[override]]
name = "github.com/aws/aws-sdk-go"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kubectl imports the aws sdk?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently :(

[[override]]
name = "github.com/docker/go-connections"
revision = "f549a9393d05688dff0992ef3efd8bbe6c628aeb"
[[override]]
name = "github.com/docker/go-units"
revision = "e30f1e79f3cd72542f2026ceec18d3bd67ab859c"
[[override]]
name = "github.com/docker/spdystream"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are all of these other changes transitive dependenices? Or did all other deps get bumped up too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All transitive dependencies. I've explicitly listed them because dep doesn't parse godep and glide files in other repos. It won't automatically detect the versions the kubernetes requests.

@colemickens
Copy link
Contributor

Thanks for satisfying my curiosity. Approved, assuming e2e passes, etc.

@ericchiang
Copy link
Contributor Author

@rphillips

19:43:33 Plugin reinitialization required. Please run "terraform init".
19:43:33 Reason: Could not satisfy plugin requirements.
19:43:33 
19:43:33 Plugins are external binaries that Terraform uses to access and manipulate
19:43:33 resources. The configuration provided requires plugins which can't be located,
19:43:33 don't satisfy the version constraints, or are otherwise incompatible.
19:43:33 
19:43:33 1 error(s) occurred:
19:43:33 
19:43:33 * provider.aws: no suitable version installed
19:43:33   version requirements: "1.8"
19:43:33   versions installed: none
19:43:33 
19:43:33 Terraform automatically discovers provider requirements from your
19:43:33 configuration, including providers used in child modules. To see the
19:43:33 requirements and constraints from each module, run "terraform providers".
19:43:33 
19:43:33 
19:43:33 Error: error satisfying plugin requirements

@ericchiang
Copy link
Contributor Author

Oh wait, this is my bad

19:42:55 [1084964.373994] golang[6]: # github.com/kubernetes-incubator/bootkube/vendor/k8s.io/kubernetes/pkg/util/parsers
19:42:55 [1084964.374555] golang[6]: vendor/k8s.io/kubernetes/pkg/util/parsers/parsers.go:36:16: undefined: reference.ParseNormalizedNamed
19:43:21 [1084990.032209] golang[6]: # github.com/kubernetes-incubator/bootkube/vendor/k8s.io/kubernetes/pkg/kubectl/cmd/templates
19:43:21 [1084990.032921] golang[6]: vendor/k8s.io/kubernetes/pkg/kubectl/cmd/templates/markdown.go:30:5: cannot use ASCIIRenderer literal (type *ASCIIRenderer) as type blackfriday.Renderer in assignment:
19:43:21 [1084990.033285] golang[6]: 	*ASCIIRenderer does not implement blackfriday.Renderer (missing RenderFooter method)
19:43:21 [1084990.033592] golang[6]: vendor/k8s.io/kubernetes/pkg/kubectl/cmd/templates/markdown.go:64:11: undefined: blackfriday.LIST_ITEM_BEGINNING_OF_LIST
19:43:21 [1084990.033934] golang[6]: vendor/k8s.io/kubernetes/pkg/kubectl/cmd/templates/markdown.go:71:11: undefined: blackfriday.LIST_TYPE_ORDERED
19:43:21 [1084990.034245] golang[6]: vendor/k8s.io/kubernetes/pkg/kubectl/cmd/templates/normalizers.go:73:35: too many arguments to conversion to blackfriday.Markdown: 

@rphillips
Copy link
Contributor

coreosbot run e2e

@ericchiang
Copy link
Contributor Author

This is becoming a mess. Going to try to address #442 instead.

@ericchiang ericchiang closed this Feb 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump vendored k8s.io repos to 1.9
4 participants