Skip to content
This repository has been archived by the owner on Sep 24, 2021. It is now read-only.

Fix the build #14

Merged
merged 1 commit into from
Jun 24, 2019
Merged

Fix the build #14

merged 1 commit into from
Jun 24, 2019

Conversation

chuckha
Copy link
Contributor

@chuckha chuckha commented Jun 24, 2019

kind-test did not compile due to API changes.

Will need to get some automated tests building these binaries soon
Signed-off-by: Chuck Ha chuckh@vmware.com

Signed-off-by: Chuck Ha <chuckh@vmware.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 24, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chuckha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2019
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 24, 2019
@chuckha
Copy link
Contributor Author

chuckha commented Jun 24, 2019

/assign @neolit123

because I saw you were looking at this already, no worries if you can't get to it

Copy link
Contributor

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2019
@k8s-ci-robot k8s-ci-robot merged commit 25dac24 into kubernetes-retired:master Jun 24, 2019
@chuckha chuckha deleted the build-fix branch August 16, 2019 02:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants