Skip to content
This repository has been archived by the owner on Sep 24, 2021. It is now read-only.

Add issue and pr templates from capa #47

Merged
merged 2 commits into from
Jun 28, 2019
Merged

Add issue and pr templates from capa #47

merged 2 commits into from
Jun 28, 2019

Conversation

ashish-amarnath
Copy link
Contributor

@ashish-amarnath ashish-amarnath commented Jun 28, 2019 •
edited
Loading

steal issue and pr templates from capa

Signed-off-by: Ashish Amarnath ashish.amarnath@gmail.com

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 28, 2019
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 28, 2019
@ashish-amarnath
steal issue and pr templates from capa
0fad001 
Signed-off-by: Ashish Amarnath ashish.amarnath@gmail.com
@detiber
Copy link
Contributor

detiber commented Jun 28, 2019

Verify job is not currently happy with whitespace:

Verifying new lines at end of files...
.github/ISSUE_TEMPLATE/bug_report.md: no newline at the end of file
.github/ISSUE_TEMPLATE/feature_request.md: no newline at the end of file
.github/PULL_REQUEST_TEMPLATE.md: no newline at the end of file
Found whitespace errors!
[*] Verifying spelling...

@detiber
Copy link
Contributor

detiber commented Jun 28, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashish-amarnath, detiber

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2019
@k8s-ci-robot k8s-ci-robot merged commit 8f5d793 into kubernetes-retired:master Jun 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@detiber detiber Awaiting requested review from detiber

@vincepri vincepri Awaiting requested review from vincepri

Assignees

@detiber detiber

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashish-amarnath @detiber @k8s-ci-robot