Skip to content
This repository has been archived by the owner on Apr 17, 2019. It is now read-only.

Provide an Ingress Controller that use Citrix NetScaler #1440

Closed
wants to merge 45 commits into from

Conversation

chiradeep
Copy link

This contribution provides an Ingress Controller that can configure a Citrix NetScaler.

chiradeep and others added 30 commits March 23, 2016 13:59
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@bprashanth
Copy link

bprashanth commented Jul 29, 2016

Firstly, thanks for the pull request.

We are in the process of dismantling the Kubernetes contrib repo into several sub-repositories as discussed on #762. With each large pull request this gets harder to do. The Ingress model is intentionally loosely coupled from the controllers so the maintenance of each one doesn't fall on the same spof (read: me).

Instead of upstreaming such a large change, can I suggest an update to the ingress docs with a link to your repository? If you're up for the docs update, please add a section to https://github.com/kubernetes/contrib/tree/master/ingress/controllers. I'm closing this pr assuming you understand the problem as described.

@bprashanth bprashanth closed this Jul 29, 2016
@thockin
Copy link
Contributor

thockin commented Jul 29, 2016

I concur with Prashanth. I don't think you get much value out of putting
it in our org or repo, at least not more than us simply linking to you.
We're happy to advise and review the kubernetes-specific parts of your
code, but the name on the repo should be your own :)

I think we'll be doing more of this.

On Thu, Jul 28, 2016 at 6:31 PM, Prashanth B notifications@github.com
wrote:

Firstly, thanks for the pull request.

We are in the process of dismantling the Kubernetes contrib repo into
several sub-repositories as discussed on #762
#762. With each large pull
request this gets harder to do. The Ingress model is intentionally losely
coupled from the controllers so the maintenance of each one doesn't fall on
the same spof (read: me).

Instead of upstreaming such a large change, can I suggest an update to the
ingress docs with a link to your repository? If you're up for the docs
update, please add a section to
https://github.com/kubernetes/contrib/tree/master/ingress/controllers.
I'm closing this pr assuming you understand the problem as described.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#1440 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFVgVMtQ7ouK_70QbFzxOM2OAjIJWNHLks5qaVfegaJpZM4JWhPT
.

@chiradeep
Copy link
Author

Makes sense, thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants