Update vendor files to point to k8s 1.12.0 #1009
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
@verult Please take a look. Thanks. |
|
Should we wait until the |
|
@verult What will release-1.12 branch change to? 1.12.1, 1.12.2,...1.12.x? |
Gopkg.toml
Outdated
| @@ -64,23 +64,23 @@ ignored = [ | |||
|
|
|||
| [[constraint]] | |||
| name = "k8s.io/api" | |||
| version = "kubernetes-1.12.0-beta.1" | |||
| branch = "release-1.12" | |||
There was a problem hiding this comment.
To guarantee all repos are in sync and compatible at e.g. VERSION=1.12.0-rc.2, use the same tag "kubernetes-$VERSION" for all k8s.io/* repos and tag "v-$VERSION" for k8s.io/kubernetes. The repos will always follow this naming scheme and have the same tags e.g. "kubernetes-1.12.0-rc.2" available at the same time
There was a problem hiding this comment.
Sure, I can use the kubernetes-1.12.0-rc.2 for everything to be consistent.
xing-yang
force-pushed
the
update_version
branch
from
7bd0f32 to
60a502b
Compare
xing-yang
changed the title
|
The contents of release-1.12 is going to keep changing and not always aligned with specific releases. Yeah I agree at the very least we should use a tagged version. Do we have to update the dependency versions now? Can we wait until 1.12.0 is out for api/apimachinery etc? We want to use that version in the end anyway right? |
|
Let's discuss about this in tomorrow's meeting and decide what to do. Thanks. |
|
Discussed about this at today's meeting. We can wait for the new tag. |
This PR updates dependency files to point to k8s 1.12.0.
xing-yang
force-pushed
the
update_version
branch
from
60a502b to
0e92469
Compare
xing-yang
changed the title
|
Updated with tag kubernetes-1.12.0 which is available now. |
|
/lgtm |
|
@wongma7 Thanks for merging this! Can you create a tag for external-storage so we can reference it in external-provisioner? |
|
@xing-yang created tag v5.2.0 |
|
@wongma7 Thanks! |
This PR updates dependency files to point to k8s 1.12.0.