Skip to content
This repository has been archived by the owner on Oct 21, 2020. It is now read-only.

Update dependencies to kubernetes v1.13.0-alpha.1 #1025

Conversation

dims
Copy link
Contributor

@dims dims commented Oct 16, 2018

This PR updates dependency files to point to k8s v1.13.0-alpha.1

  • v1.13.0-alpha.1 is a tag (not a branch)
  • all the staging repositories like k/api etc have been tagged properly

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 16, 2018
@dims dims force-pushed the update-dependencies-to-kubernetes-v1.13.0-alpha.1 branch from a75e45c to 3d52e01 Compare October 16, 2018 12:57
@dims
Copy link
Contributor Author

dims commented Oct 16, 2018

/assign @wongma7
/assign @xing-yang

@k8s-ci-robot
Copy link
Contributor

@dims: GitHub didn't allow me to assign the following users: xing-yang.

Note that only kubernetes-incubator members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

/assign @wongma7
/assign @xing-yang

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dims dims force-pushed the update-dependencies-to-kubernetes-v1.13.0-alpha.1 branch from 3d52e01 to 16a785b Compare October 16, 2018 13:02
Gopkg.toml Outdated

[[constraint]]
name = "k8s.io/client-go"
version = "kubernetes-1.12.0"
version = "v9.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need kubernetes-1.13.0-alpha.1 as well, there is something different between 1.13 and v9.0.0 in client-go/transport

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. my bad, fixing

@dims dims force-pushed the update-dependencies-to-kubernetes-v1.13.0-alpha.1 branch from 16a785b to 135a088 Compare October 16, 2018 14:48
Change-Id: I52caf73749d558383860a9b025f71dd9d5271c1d
@dims dims force-pushed the update-dependencies-to-kubernetes-v1.13.0-alpha.1 branch from 135a088 to 85539e4 Compare October 16, 2018 14:55
@dims
Copy link
Contributor Author

dims commented Oct 16, 2018

@wongma7 the builds are green now :)

@wongma7
Copy link
Contributor

wongma7 commented Oct 16, 2018

thx, merging. I'm working on https://github.com/kubernetes-sigs/sig-storage-lib-external-provisioner so hopefully this will be the last time we need to do this..
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 16, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2018
@k8s-ci-robot k8s-ci-robot merged commit a36eb11 into kubernetes-retired:master Oct 16, 2018
@dims
Copy link
Contributor Author

dims commented Oct 16, 2018

@wongma7 is it possible to create a tag as well? i need to use this in cloud-provider-openstack

@wongma7
Copy link
Contributor

wongma7 commented Oct 16, 2018

@dims
Copy link
Contributor Author

dims commented Oct 16, 2018

nice! thanks @wongma7

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants