Update all k8s.io dependencies to 1.8.2 and add support for Retain reclaim policy to lib/controller

[wongma7]

this is a continuation of #392

snapshots needs some code changes because of changes to kuberentes' internal API.

other than that, we are fine.

@xingzhou we can contniue work in #392 if I submit a PR against your branch, or we can fix it here. up to you!

[wongma7]

$ make snapshot
cd snapshot; \
make
make[1]: Entering directory '/home/mawong/src/github.com/kubernetes-incubator/external-storage/snapshot'
go build -o _output/bin/snapshot-controller cmd/snapshot-controller/snapshot-controller.go
# github.com/kubernetes-incubator/external-storage/snapshot/pkg/apis/crd/v1
pkg/apis/crd/v1/register.go:52: cannot use VolumeSnapshot literal (type *VolumeSnapshot) as type runtime.Object in argument to scheme.AddKnownTypes:
	*VolumeSnapshot does not implement runtime.Object (missing DeepCopyObject method)
pkg/apis/crd/v1/register.go:53: cannot use VolumeSnapshotList literal (type *VolumeSnapshotList) as type runtime.Object in argument to scheme.AddKnownTypes:
	*VolumeSnapshotList does not implement runtime.Object (missing DeepCopyObject method)
pkg/apis/crd/v1/register.go:54: cannot use VolumeSnapshotData literal (type *VolumeSnapshotData) as type runtime.Object in argument to scheme.AddKnownTypes:
	*VolumeSnapshotData does not implement runtime.Object (missing DeepCopyObject method)
pkg/apis/crd/v1/register.go:55: cannot use VolumeSnapshotDataList literal (type *VolumeSnapshotDataList) as type runtime.Object in argument to scheme.AddKnownTypes:
	*VolumeSnapshotDataList does not implement runtime.Object (missing DeepCopyObject method)
pkg/apis/crd/v1/types.go:292: cannot use &vd.Metadata (type *"github.com/kubernetes-incubator/external-storage/vendor/k8s.io/apimachinery/pkg/apis/meta/v1".ListMeta) as type "github.com/kubernetes-incubator/external-storage/vendor/k8s.io/apimachinery/pkg/apis/meta/v1".List in return argument
pkg/apis/crd/v1/types.go:312: cannot use &vd.Metadata (type *"github.com/kubernetes-incubator/external-storage/vendor/k8s.io/apimachinery/pkg/apis/meta/v1".ListMeta) as type "github.com/kubernetes-incubator/external-storage/vendor/k8s.io/apimachinery/pkg/apis/meta/v1".List in return argument

I will work on fixing this issue. everything else seems okay.

[xingzhou]

@wongma7, does this PR contain all the changes I made in #392?

[wongma7]

Yes, all I’ve done so far is change from commit hash to 1.8.1 tag and test it pass ci. But next have to fix snapshots, which depends on the changes in your pr

…

On Wed, Oct 25, 2017 at 12:15 AM Tom Xing ***@***.***> wrote: @wongma7 <https://github.com/wongma7>, does this PR contain all the changes I made in #392 <#392>? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#419 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AMgP-DRmm9L88OrR7F0XqEnLR6JVXnPcks5svrXegaJpZM4QFFx9> .

[xingzhou]

yeap, is there any reason that we need to share dependency with snapshot? to me, snapshot is some kind of independent code, which will be compiled on its own

[sbezverk]

@wongma7 it seems going with 1.8.1 tags is not enough for some newer api objects as in the latest CI failure for CephFS.

[wongma7]

• @sbezverk ty for heads up about cephfs, added TODO for Ceph provisioner requires creating secrets in PVC namespaces #309 , cephFS namespace issue @rootfs
• Added deepcopy funcs for snapshot API, CRD requires we implement them. @tsmetana PTAL

I will squash the first 3 commits @xingzhou

Then we can get this merged finally. Sorry for the month-long delay everybody.

[wongma7]

Forgot to say, for the snapshot changes I ran

$ ./generate-groups.sh deepcopy github.com/kubernetes-incubator/external-storage/snapshot/pkg/apis github.com/kubernetes-incubator/external-storage/snapshot/pkg/apis "crd:v1"

from https://github.com/kubernetes/code-generator to get zz_generated.deepcopy.go. And manually fixed the broken ones and put into deepcopy.go. (The structs that have a member of external type i.e. from core_v1)

[sbezverk]

@wongma7 if it is possible, could you please add recent merged api change to support RBDPersistentVolumeSource which was added last week? In this case RBD provisioner can be refactored to use it.

[wongma7]

nobody wants to review, merging

[tsmetana]

Sorry for the slow response: I was AFK for the past few days... I think it's OK to merge this anyway. Thanks.

[sbezverk]

@wongma7 Tested for RBD, the change looks good, now SecretReference is available. I still see the issue for new RBDPersistentVolumeSource though, I guess it will be addressed in the next PR.

pkg/provision/provision.go:114: undefined: "github.com/kubernetes-incubator/external-storage/vendor/k8s.io/api/core/v1".RBDPersistentVolumeSource
Makefile:27: recipe for target 'build' failed