This repository has been archived by the owner on Sep 24, 2021. It is now read-only.
better cni compatibility #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
YaoZengzeng
force-pushed
the
cni-compatible
branch
from
2c2c686
to
9f81f1b
Compare
Signed-off-by: YaoZengzeng <zengzengyao@harmonycloud.cn>
YaoZengzeng
force-pushed
the
cni-compatible
branch
from
9f81f1b
to
84afc84
Compare
feiskyer
suggested changes
Aug 7, 2017
| func buildNetworkInfo(bridgeName string, cniResult *current.Result) *NetworkInfo { | ||
| ret := &NetworkInfo{} | ||
|
|
||
| ret.BridgeName = bridgeName |
There was a problem hiding this comment.
Should also generate the Ifname with same bridge suffix, e.g. for bridge br1a089c6f, generate a tap1a089c6f.
Signed-off-by: YaoZengzeng <zengzengyao@harmonycloud.cn>
YaoZengzeng
force-pushed
the
cni-compatible
branch
from
84afc84
to
32564f3
Compare
Signed-off-by: YaoZengzeng <zengzeng@harmonycloud.cn>
YaoZengzeng
force-pushed
the
cni-compatible
branch
from
32564f3
to
ada8a33
Compare
Signed-off-by: Yao Zengzeng <zengzengyao@harmonycloud.cn>
feiskyer
approved these changes
Aug 8, 2017
|
/lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #191