This repository has been archived by the owner on Sep 24, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
label
Aug 20, 2017
I'm not sure if this test is designed correctly, you can just think of it as a sample. |
@LilyFaFa Thanks very much. Please refer docker fake client for adding a fakeClient. Generally, it should
|
k8s-ci-robot
added
the
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
label
Aug 25, 2017
@feiskyer Thank you for your advice,I have updated the code by referring to the item in the link,this is the new code. |
@LilyFaFa Thanks. Seems the PR includes some changes already merged. Could you make a rebase toward master? |
@feiskyer Please have a look ,is this time ok? |
/lgtm |
@LilyFaFa Thanks a lot |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
lgtm
Indicates that a PR is ready to be merged.
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.