This repository has been archived by the owner on Sep 24, 2021. It is now read-only.
Add metadata store and basic unikernel service #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
k8s-ci-robot
added
the
size/XXL
Crazykev
force-pushed
the
unikernel-service
branch
2 times, most recently
from
c9d28d2
to
c21de0c
Compare
feiskyer
reviewed
Aug 28, 2017
| - hack/install-protoc.sh | ||
| - hack/install-hypercontainer.sh | ||
| - go install -v $(go list ./... | grep -v /vendor/) |
There was a problem hiding this comment.
@feiskyer I've introduce libvirt-go dependency in this patch, when go install libvirt-go, it will try to build it, and it need libvirt-dev lib to do that. We installed this lib in hack/install-hypercontainer.sh, so I changed this order to install libvirt-dev first.
BTW, new patch is on the way, thanks for reviewing.
There was a problem hiding this comment.
OK, that makes sense. thanks
|
Also this PR needs a rebase now. |
Signed-off-by: Crazykev <crazykev@zju.edu.cn>
Signed-off-by: Crazykev <crazykev@zju.edu.cn>
Signed-off-by: Crazykev <crazykev@zju.edu.cn>
Signed-off-by: Crazykev <crazykev@zju.edu.cn>
Signed-off-by: Crazykev <crazykev@zju.edu.cn>
Signed-off-by: Crazykev <crazykev@zju.edu.cn>
Crazykev
force-pushed
the
unikernel-service
branch
from
c21de0c
to
1d4cd06
Compare
|
/lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will bring container and VM workflow when test is enough
@feiskyer @resouer PTAL