Skip to content
This repository has been archived by the owner on Sep 24, 2021. It is now read-only.

Install right version of critool #313

Merged
merged 1 commit into from
Mar 17, 2018

Conversation

resouer
Copy link
Contributor

@resouer resouer commented Mar 16, 2018

Download from release directly.

@resouer resouer requested a review from bergwolf March 16, 2018 04:07
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 16, 2018
@resouer
Copy link
Contributor Author

resouer commented Mar 16, 2018

Em ... we have to also checkout the repo in $GOPATH to right version.

2018-03-16 23:13:00 (6.05 MB/s) - ‘critest-v1.0.0-alpha.0-linux-amd64.tar.gz’ saved [7408681/7408681]
can't load package: package github.com/kubernetes-incubator/cri-tools/pkg/validate: cannot find package "github.com/kubernetes-incubator/cri-tools/pkg/validate" in any of:
	/home/travis/.gimme/versions/go1.9.4.linux.amd64/src/github.com/kubernetes-incubator/cri-tools/pkg/validate (from $GOROOT)

@bergwolf
Copy link
Contributor

critools build failed:


can't load package: package github.com/kubernetes-incubator/cri-tools/pkg/validate: cannot find package "github.com/kubernetes-incubator/cri-tools/pkg/validate" in any of:
	/home/travis/.gimme/versions/go1.9.4.linux.amd64/src/github.com/kubernetes-incubator/cri-tools/pkg/validate (from $GOROOT)
	/home/travis/gopath/src/github.com/kubernetes-incubator/cri-tools/pkg/validate (from $GOPATH)
F0316 23:13:00.623023   28365 util.go:106] Failed to build the dependencies: build test suite failed: exit status 1]

@resouer
Copy link
Contributor Author

resouer commented Mar 17, 2018

Yep noticed that.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 17, 2018
@resouer resouer merged commit 86cb9c0 into kubernetes-retired:master Mar 17, 2018
@resouer resouer deleted the fix-critool branch March 17, 2018 04:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants