Skip to content
This repository has been archived by the owner on Dec 1, 2018. It is now read-only.

Fix ElasticSearch sink mapping #1276

Merged
merged 1 commit into from
Sep 2, 2016
Merged

Fix ElasticSearch sink mapping #1276

merged 1 commit into from
Sep 2, 2016

Conversation

AlmogBaku
Copy link
Contributor

@AlmogBaku AlmogBaku commented Sep 2, 2016 •
edited by thockin
Loading

fixes #1262 :

  • mapping fields as well (keeps an indexable and raw versions of most of the strings)
  • added an alias in order to create to indexes in kibana

This change is Reviewable

@AlmogBaku
Copy link
Contributor Author

cc @huangyuqi @piosz

@AlmogBaku AlmogBaku changed the title Fix es mapping Fix ElasticSearch sink mapping Sep 2, 2016
piosz
piosz reviewed Sep 2, 2016
View reviewed changes
Makefile
@@ -31,7 +31,8 @@ test-integration: clean deps build
container: build
cp heapster deploy/docker/heapster
cp eventer deploy/docker/eventer
docker build -t $(PREFIX)/heapster:$(TAG) deploy/docker/
docker build -t heapster deploy/docker/
docker tag heapster:latest 032833530291.dkr.ecr.eu-west-1.amazonaws.com/heapster:latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this?

Copy link
Contributor Author

@AlmogBaku AlmogBaku Sep 2, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@piosz my bad. fixed.

(I used it to deploy to my local registry and test)

@piosz
Copy link
Contributor

piosz commented Sep 2, 2016

Please squash commits

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

1 similar comment
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@googlebot googlebot added cla: no and removed cla: yes labels Sep 2, 2016
@AlmogBaku
fixes kubernetes-retired#1262 :
4dee570 
 - mapping fields as well (keeps an indexable and raw versions of most of the strings)
 - added an alias in order to create to indexes in kibana
@piosz
Copy link
Contributor

piosz commented Sep 2, 2016

Something went wrong with your rebase.

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Sep 2, 2016
@piosz
Copy link
Contributor

piosz commented Sep 2, 2016

LGTM from me. Waiting for @huangyuqi

@huangyuqi
Copy link

LGTM

@piosz piosz added the lgtm Indicates that a PR is ready to be merged. label Sep 2, 2016
@piosz
Copy link
Contributor

piosz commented Sep 2, 2016

Thanks for the PR and the review.

@piosz piosz merged commit 00ec0ad into kubernetes-retired:master Sep 2, 2016
@AlmogBaku AlmogBaku mentioned this pull request Sep 2, 2016
Closed
18 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ElasticSearch data is not mapped well
4 participants
@AlmogBaku @piosz @googlebot @huangyuqi