Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

kubernetes.io/cluster/<Cluster ID> tag should have a valid value #1025

Closed
mumoshu opened this issue Nov 22, 2017 · 1 comment
Closed

kubernetes.io/cluster/<Cluster ID> tag should have a valid value #1025

mumoshu opened this issue Nov 22, 2017 · 1 comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Milestone
v0.9.9

Comments

@mumoshu
Copy link
Contributor

mumoshu commented Nov 22, 2017

It should be either owned or shared but is now true.

Ref: https://github.com/kubernetes/kubernetes/blob/v1.8.3/pkg/cloudprovider/providers/aws/tags.go#L44-L51
@mumoshu mumoshu added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Nov 22, 2017
@mumoshu mumoshu changed the title kubernetes.io/cluster/<cluster name> tag should have a valid value kubernetes.io/cluster/<Cluster ID> tag should have a valid value Nov 22, 2017
mumoshu added a commit to mumoshu/kube-aws that referenced this issue Dec 8, 2017
@mumoshu
Correct values for the kubernetes.io/cluster/<Cluster ID> tags
62d0209 
Resolves kubernetes-retired#1025
@mumoshu mumoshu mentioned this issue Dec 8, 2017
Merged
@mumoshu
Copy link
Contributor Author

mumoshu commented Dec 8, 2017

I was bitten by this badly, more than I have imagined.

This is just an example but kube-ingress-aws-controller requires this tag to have the exact value "owned". Otherwise, it doesn't work due to failing to discover ASGs used to determine which subnets an ALB should be created.

@mumoshu mumoshu added this to the v0.9.9 milestone Dec 8, 2017
camilb added a commit to camilb/kube-aws that referenced this issue Dec 11, 2017
@camilb
Merge branch 'master' of https://github.com/kubernetes-incubator/kube…
0ce26f9 
…-aws into updates

* 'master' of https://github.com/kubernetes-incubator/kube-aws:
  Allow toggling Metrics Server installation
  Correct values for the `kubernetes.io/cluster/<Cluster ID>` tags Resolves kubernetes-retired#1025
  Fix dashboard doco links
  Fix install-kube-system when node drainer is enabled Follow-up for kubernetes-retired#1043
  Two fixes to 0.9.9 rc.3 (kubernetes-retired#1043)
  Quick start and high availability guides
camilb added a commit to camilb/kube-aws that referenced this issue Jan 5, 2018
@camilb
Merge remote-tracking branch 'kubernetes-incubator/master'
91c315e 
* kubernetes-incubator/master:
  Move Experimental.IPVSProxy => KubeProxy.IPVSMode
  Optional functionality is optional
  Add option for using IPVS proxy mode
  Update code-of-conduct.md
  controlplane config: Enable Pod Priorities
  Allow toggling Metrics Server installation
  Correct values for the `kubernetes.io/cluster/<Cluster ID>` tags Resolves kubernetes-retired#1025
  Fix dashboard doco links
  Fix install-kube-system when node drainer is enabled Follow-up for kubernetes-retired#1043
  Two fixes to 0.9.9 rc.3 (kubernetes-retired#1043)
@rossf7 rossf7 mentioned this issue Jan 24, 2018
Closed
davidmccormick pushed a commit to HotelsDotCom/kube-aws that referenced this issue Mar 21, 2018
Merge pull request kubernetes-retired#27 in RUN/kube-aws from hcom-fl…
f40e443 
…avour-0.9.9 to hcom-flavour

* commit '0e116d72ead70121c730d3bc4009f8d562e16912': (24 commits)
  RUN-788 Add kubectl run parameters
  Allow toggling Metrics Server installation
  Correct values for the `kubernetes.io/cluster/<Cluster ID>` tags Resolves kubernetes-retired#1025
  Fix dashboard doco links
  Fix install-kube-system when node drainer is enabled Follow-up for kubernetes-retired#1043
  Two fixes to 0.9.9 rc.3 (kubernetes-retired#1043)
  Update the documentation for Kubernetes Dashboard.
  Improve the configuration for Kubernetes Dashboard.
  Fix the creation of all metrics-server resources.
  Use templated image for metrics-server.
  Follow-ups for Kubernetes 1.8
  Metrics Server addon. (kubernetes-retired#973)
  Quick start and high availability guides
  Add rkt container cleanup to journald-cloudwatch-logs service
  Update Tiller image to v2.7.2
  Update kube-dns 1.14.7
  Bump Cluster Autoscaler version to 1.0.3
  Bump Kubernetes and ETCD version.
  Support EC2 instance tags per node role This feature will be handy when e.g. your monitoring tools discovers EC2 instances and then groups resource metrics with EC2 instance tags.
  Fix the default FleetIamRole Closes kubernetes-retired#1022
  ...
kylehodgetts pushed a commit to HotelsDotCom/kube-aws that referenced this issue Mar 27, 2018
@mumoshu
Correct values for the kubernetes.io/cluster/<Cluster ID> tags
6510561 
Resolves kubernetes-retired#1025
laidback added a commit to laidback/openshift-docs that referenced this issue Apr 23, 2018
@laidback
Update configuring_aws.adoc
87254e0 
Update the document to conform with:
kubernetes-retired/kube-aws#1025
https://github.com/kubernetes/kubernetes/blob/v1.8.3/pkg/cloudprovider/providers/aws/tags.go#L44-L51
This was referenced Apr 23, 2018
Open
Closed
kalexand-rh pushed a commit to kalexand-rh/openshift-docs that referenced this issue Jun 26, 2018
@laidback @kalexand-rh
Update configuring_aws.adoc
3e3e71c 
Update the document to conform with:
kubernetes-retired/kube-aws#1025
https://github.com/kubernetes/kubernetes/blob/v1.8.3/pkg/cloudprovider/providers/aws/tags.go#L44-L51
@kalexand-rh kalexand-rh mentioned this issue Jun 26, 2018
Merged
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/openshift-docs that referenced this issue Jun 28, 2018
@laidback
Update configuring_aws.adoc
3dd841f 
Update the document to conform with:
kubernetes-retired/kube-aws#1025
https://github.com/kubernetes/kubernetes/blob/v1.8.3/pkg/cloudprovider/providers/aws/tags.go#L44-L51
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/openshift-docs that referenced this issue Jun 28, 2018
@laidback
Update configuring_aws.adoc
8d075e9 
Update the document to conform with:
kubernetes-retired/kube-aws#1025
https://github.com/kubernetes/kubernetes/blob/v1.8.3/pkg/cloudprovider/providers/aws/tags.go#L44-L51
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/openshift-docs that referenced this issue Jun 28, 2018
@laidback
Update configuring_aws.adoc
868c21a 
Update the document to conform with:
kubernetes-retired/kube-aws#1025
https://github.com/kubernetes/kubernetes/blob/v1.8.3/pkg/cloudprovider/providers/aws/tags.go#L44-L51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Milestone
v0.9.9
Development

No branches or pull requests
1 participant
@mumoshu