This repository has been archived by the owner on Sep 30, 2020. It is now read-only.
Fix the default FleetIamRole #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kube-node-label now retries until at most 10 seconds pass. It is 7 seconds longer for controllers and 10 seconds longer for workers. Resolves kubernetes-retired#866
k8s-ci-robot
added
cncf-cla: yes
|
I've manually verified this to work by adding a spot-fleet based node pool to my cluster. |
Codecov Report
@@ Coverage Diff @@
## master #1024 +/- ##
=======================================
Coverage 34.91% 34.91%
=======================================
Files 59 59
Lines 4159 4159
=======================================
Hits 1452 1452
Misses 2545 2545
Partials 162 162
Continue to review full report at Codecov.
|
kylehodgetts
pushed a commit
to HotelsDotCom/kube-aws
that referenced
this pull request
Mar 27, 2018
…am-fleet-role Fix the default FleetIamRole
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1022
Depends on #1023
Please see the third commit for reviewing changes independently from the PR this is dependent on.