Skip to content
This repository has been archived by the owner on Apr 22, 2020. It is now read-only.

phase3: update to flannel 1.10 #568

Closed

Conversation

neolit123
Copy link
Contributor

@neolit123 neolit123 commented Sep 25, 2018

the flannel version is k-a is outdated, this PR updates to the latest flannel - 0.10.0.

trying to solve:
https://k8s-testgrid.appspot.com/sig-network-gce#kubeadm-gce-cni-flannel

latest flannel doesn't work for me locally at all with 1.12.x and the guide here:
https://kubernetes.io/docs/setup/independent/create-cluster-kubeadm/#pod-network
i need to investigate further.

also, putting this PR on hold because i haven't tested it with k-a yet.

/hold
/kind bug
/area
/assign @fabriziopandini
@kubernetes/sig-cluster-lifecycle-pr-reviews
@kubernetes/sig-network-pr-reviews

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 25, 2018
@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to sig-cluster-lifecycle. kind/bug Categorizes issue or PR as related to a bug. sig/network Categorizes an issue or PR as relevant to sig-network. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 25, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: neolit123

If they are not already assigned, you can assign the PR to them by writing /assign @neolit123 in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 25, 2018
@fabriziopandini
Copy link

@neolit123 thanks for this PR!
Take your time for testing; I think we should hold any change to k/a until release cut + some days

@neolit123
Copy link
Contributor Author

closing this because we are not going to maintain flannel in k-a:
kubernetes/test-infra#9539 (comment)

on a related note flannel is broken in 1.12 due to this:
flannel-io/flannel#1045

sadly, flannel itself is hardly maintained.

@neolit123 neolit123 closed this Oct 2, 2018
@ReSearchITEng
Copy link

For anyone willing to test the flannel fix for 1.12 further,
kubeadm -n kube-system apply -f https://raw.githubusercontent.com/coreos/flannel/bc79dd1505b0c8681ece4de4c0d86c5cd2643275/Documentation/kube-flannel.yml

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/bug Categorizes issue or PR as related to a bug. sig/cluster-lifecycle Categorizes an issue or PR as relevant to sig-cluster-lifecycle. sig/network Categorizes an issue or PR as relevant to sig-network. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants