This repository has been archived by the owner on Jun 26, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 173
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Sync object propagation on newly labeled namespaces
Fix 1448 Detect namespace label changes. If the labels are updated, ensure syncing all the objects (including non-existing yet but possible propagated objects) in the namespace, so that we will not miss any propagation label changes that should trigger propagation or unpropagation. Add integration tests in reconciler/object_test.go. Tested manually that labeling and unlabeling a child with the propagate label won't do anything before the fix, but triggers propagation and unpropagation accordingly after the fix. Also tested with `make test`, passed after the fix ant failed before the fix.
- Loading branch information
1 parent
ae0b4fe
commit 8ace87b
Showing
4 changed files
with
138 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters