This repository has been archived by the owner on Jun 26, 2023. It is now read-only.
Fix a nil pointer issue in HC webhook when setting as root #1121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bug was found when running e2e tests that the webhook got INTERNAL_ERROR when setting a namespace as root. Fix it by checking if the new parent is nil. If yes, early exit since it's impossible to introduce new naming conflicts. Add a new unit test case for it. The test failed before and passed after the change. Tested by make test and manually.
k8s-ci-robot
added
cncf-cla: yes
|
/assign @adrianludwin This is a bug fix. The bug was found when running e2e tests in #1115 . Will cherry-pick this PR into #1115 after it's merged. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianludwin, yiqigao217 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug was found when running e2e tests that the webhook got
INTERNAL_ERROR when setting a namespace as root. Fix it by checking if
the new parent is nil. If yes, early exit since it's impossible to
introduce new naming conflicts.
Add a new unit test case for it. The test failed before and passed after
the change.
Tested by make test and manually.