This repository has been archived by the owner on Jun 26, 2023. It is now read-only.
Fix netpol e2e test #1244
Merged
Fix netpol e2e test #1244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test was failing incorrectly; it now passes if netpols are enabled and is skipped if they're not. Tested: on GKE with netpol enabled and on Kind with them disabled.
k8s-ci-robot
added
the
cncf-cla: yes
|
/assign @GinnyJI |
k8s-ci-robot
added
size/M
yiqigao217
reviewed
Oct 28, 2020
There was a problem hiding this comment.
/lgtm
/hold
Just 1 question and wait for @GinnyJI for another eye.
| for i:=0; !netpolWorks && i<3; i++ { | ||
| // This command will return a non-nil error if it works correctly | ||
| stdout, _ := RunCommand(clientCmd, nsService1, alpineArgs, wgetArgs) | ||
| if strings.Contains(stdout, "wget: download timed out") { |
There was a problem hiding this comment.
Question: If the netpol is not enabled in the cluster it will just get "Welcome to nginx!", right?
k8s-ci-robot
added
do-not-merge/hold
|
Exactly, yes.
…On Wed, Oct 28, 2020 at 12:12 PM Yiqi Gao ***@***.***> wrote:
***@***.**** commented on this pull request.
/lgtm
/hold
Just 1 question and wait for @GinnyJI <https://github.com/GinnyJI> for
another eye.
------------------------------
In incubator/hnc/test/e2e/quickstart_test.go
<#1244 (comment)>
:
> - netpolTestStdout := ""
- Eventually(func() error {
- stdout, err := RunCommand("kubectl run client -n", nsService1, clientArgs, cmdln)
- netpolTestStdout = stdout
- return err
- }).Should(Succeed())
- if !strings.Contains(netpolTestStdout, "wget: download timed out") {
+ //
+ // The standard matching functions won't work here because we're looking for a particular error
+ // string, but we don't want to fail if we've found it. So use the default timeout (2s) by
+ // trying up to three times with a 1s gap in between.
+ netpolWorks := false
+ for i:=0; !netpolWorks && i<3; i++ {
+ // This command will return a non-nil error if it works correctly
+ stdout, _ := RunCommand(clientCmd, nsService1, alpineArgs, wgetArgs)
+ if strings.Contains(stdout, "wget: download timed out") {
Question: If the netpol is not enabled in the cluster it will just get
"Welcome to nginx!", right?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1244 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE43PZGL4OCCB7PXU3ABUIDSNA7IRANCNFSM4TCQCV7A>
.
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianludwin, GinnyJI The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test was failing incorrectly; it now passes if netpols are enabled
and is skipped if they're not.
Tested: on GKE with netpol enabled and on Kind with them disabled.