This repository has been archived by the owner on Jun 26, 2023. It is now read-only.
Enable removing bad subns anchors safely #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
|
/hold until #788 is merged (both changed anchor validator and its unit test) |
k8s-ci-robot
added
the
do-not-merge/hold
|
Please hold review on this, I will let you know once it's ready. |
k8s-ci-robot
added
the
needs-rebase
k8s-ci-robot
added
size/L
yiqigao217
changed the title
|
Hi @adrianludwin and @rjbez17, it's ready for review now. |
Allow removing bad subns anchor if the subnamespace already exists and the parent doesn't match. The race condition could happen when two parents both create the same subns the same time and the webhook is bypassed because the forest is not updated after the first change. We would always allow resolving a bad state. Most importantly, make sure the subnamespace is not deleted with the deletion of a bad anchor. Before this change, the subnamespace created from a good anchor will also be deleted when deleting a bad anchor. Tested by test-issue-797-leaf.sh and test-issue-797-non-leaf.sh, where they disable the webhook first to generate the race condition in both a leaf and non-leaf subnamespace and enable the webhook to test the change. One unit test case is added to the anchor validator too.
k8s-ci-robot
added
lgtm
|
Hi @adrianludwin , I also changed the ensuring of the subnamespace is not deleted by seeing the created secret is still there instead of matching the creatingTimestamp. |
|
/lgtm |
k8s-ci-robot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianludwin, rjbez17, yiqigao217 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow removing bad subns anchor if the subnamespace already exists and
the parent doesn't match. The race condition could happen when two
parents both create the same subns the same time and the webhook is
bypassed because the forest is not updated after the first change. We
would always allow resolving a bad state.
Most importantly, make sure the subnamespace is not deleted with the
deletion of a bad anchor. Before this change, the subnamespace created
from a good anchor will also be deleted when deleting a bad anchor.
Tested by test-issue-797-leaf.sh and test-issue-797-non-leaf.sh, where
they disable the webhook first to generate the race condition in both a
leaf and non-leaf subnamespace and enable the webhook to test the
change. One unit test case is added to the anchor validator too.
Fixes #797