-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement rest.Scoper, return filesystem errors fixes #549 #550
implement rest.Scoper, return filesystem errors fixes #549 #550
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: drewwells The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f5f1deb
to
9e55862
Compare
the bot is complaining at the commit message, can you revise? |
what is it asking me to do? I didn't find a clear error message to correct. |
9e55862
to
7969a13
Compare
Keywords which can automatically close issues and at(@) mentions are not allowed in commit messages. The list of commits with invalid commit messages:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@yue9944882 was the jsonfile removed on purpose? https://github.com/kubernetes-sigs/apiserver-builder-alpha/pull/538/files#diff-4264db30cf16db2b2bfe965c1d4855dc8852f7a8983be3caef5244186cae547f I found the example of a custom storage to be quite useful. burger_rest.go also still refers to it so this will lead to a compilation error. |
7969a13
to
c49fd70
Compare
/remove-label do-not-merge/invalid-commit-message it's complaining about fixes keyword probably |
@drewwells: The label(s) `/remove-label do-not-merge/invalid-commit-message
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
return filesystem errors
c49fd70
to
0dd964a
Compare
Keywords which can automatically close issues and at(@) mentions are not allowed in the title of a Pull Request. You can edit the title by writing /retitle in a comment.
When GitHub merges a Pull Request, the title is included in the merge commit. To avoid invalid keywords in the merge commit, please edit the title of the PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@drewwells yes this will be moved to apiserver-runtime per #541, the mysql storage has already been moved to https://github.com/kubernetes-sigs/apiserver-runtime/tree/main/pkg/experimental/storage/mysql, will be working on jsonfilepath very soon |
Can we add it to apiserver before removing it here. The examples won’t build now |
No description provided.