Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement rest.Scoper, return filesystem errors fixes #549 #550

Merged
merged 1 commit into from
Oct 26, 2020

Conversation

drewwells
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 20, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: drewwells
To complete the pull request process, please assign directxman12 after the PR has been reviewed.
You can assign the PR to them by writing /assign @directxman12 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yue9944882
Copy link
Member

the bot is complaining at the commit message, can you revise?

@drewwells
Copy link
Contributor Author

the bot is complaining at the commit message, can you revise?

what is it asking me to do? I didn't find a clear error message to correct.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 22, 2020
@k8s-ci-robot
Copy link
Contributor

Keywords which can automatically close issues and at(@) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 22, 2020
@drewwells
Copy link
Contributor Author

@yue9944882 was the jsonfile removed on purpose? https://github.com/kubernetes-sigs/apiserver-builder-alpha/pull/538/files#diff-4264db30cf16db2b2bfe965c1d4855dc8852f7a8983be3caef5244186cae547f

I found the example of a custom storage to be quite useful. burger_rest.go also still refers to it so this will lead to a compilation error.

@drewwells
Copy link
Contributor Author

/remove-label do-not-merge/invalid-commit-message

it's complaining about fixes keyword probably

@k8s-ci-robot
Copy link
Contributor

@drewwells: The label(s) `/remove-label do-not-merge/invalid-commit-message

cannot be applied. These labels are supported:api-review, community/discussion, community/maintenance, community/question, cuj/build-train-deploy, cuj/multi-user, platform/aws, platform/azure, platform/gcp, platform/minikube, platform/other, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash`

In response to this:

/remove-label do-not-merge/invalid-commit-message

it's complaining about fixes keyword probably

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

return filesystem errors
@k8s-ci-robot
Copy link
Contributor

Keywords which can automatically close issues and at(@) mentions are not allowed in the title of a Pull Request.

You can edit the title by writing /retitle in a comment.

When GitHub merges a Pull Request, the title is included in the merge commit. To avoid invalid keywords in the merge commit, please edit the title of the PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yue9944882
Copy link
Member

@drewwells
Copy link
Contributor Author

Can we add it to apiserver before removing it here. The examples won’t build now

@k8s-ci-robot k8s-ci-robot merged commit 0dd964a into kubernetes-sigs:master Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants