Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to change kubelet default path #448

Closed
Amos-85 opened this issue Feb 13, 2020 · 15 comments · Fixed by #856
Closed

Add ability to change kubelet default path #448

Amos-85 opened this issue Feb 13, 2020 · 15 comments · Fixed by #856
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@Amos-85
Copy link

Amos-85 commented Feb 13, 2020

There is no option in the helm chart values file to define the kubelet mountPath

it would be nice if we can define it if some cluster has some kubelet path other then the default one which is /var/lib/kubelet

@leakingtapan
Copy link
Contributor

Hey @Amos-85 thx for reporting the issue. Could you add more details on why "some cluster has some kubelet path other then the default one"?

@Amos-85
Copy link
Author

Amos-85 commented Feb 13, 2020

Hi @leakingtapan
Case 1

  • RKE use this path /opt/rke/var/lib/kubelet as default.

Case 2

  • Sometimes you don't want to deploy k8s components under root paths cause of small root fs.

@leakingtapan
Copy link
Contributor

It is possible now if you update the path yourself here: https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/deploy/kubernetes/base/node.yaml#L38 if this is the path being concerned?

@Amos-85
Copy link
Author

Amos-85 commented Mar 30, 2020

@leakingtapan, the file you mentioned refer to kustimize, not for the helm chart.

the /var/lib/kubelet is not template in the helm chart:
as-daemonset-reference

@leakingtapan
Copy link
Contributor

Yep. the above is a workaround while the path is not configurable. You could either manually edit the helm or kustomize file.

But free feel to submit a PR to make helm configubale, I will review the change

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 1, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 31, 2020
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@leakingtapan
Copy link
Contributor

/reopen

@k8s-ci-robot
Copy link
Contributor

@leakingtapan: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot reopened this Feb 17, 2021
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wongma7
Copy link
Contributor

wongma7 commented Mar 19, 2021

/reopen
/help-wanted
/lifecycle frozen

more configuration options welcome.

@k8s-ci-robot k8s-ci-robot reopened this Mar 19, 2021
@k8s-ci-robot
Copy link
Contributor

@wongma7: Reopened this issue.

In response to this:

/reopen
/help-wanted
/lifecycle frozen

more configuration options welcome.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
5 participants