-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chart] Support image.pullPolicy for csi-resizer image #1045
[chart] Support image.pullPolicy for csi-resizer image #1045
Conversation
Hi @jyaworski. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I didn't think about it before, but make sure to run make generate-kustomize
and push the changes to the deploy manifests.
@vdhanan will you add an okay to test? |
/ok-to-test |
919cb92
to
d709ac4
Compare
d709ac4
to
57ba577
Compare
Signed-off-by: Joseph (Jy) Yaworski <jyaworski@carotid.us>
57ba577
to
cb6d292
Compare
@jyaworski I am not an owner so I can't approve this to merge |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jyaworski, krmichel, vdhanan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Joseph (Jy) Yaworski jyaworski@carotid.us
Is this a bug fix or adding new feature?
Fixes #1040
What is this PR about? / Why do we need it?
Adds support for image.pullPolicy to another container previously hardcoded
What testing is done?
ct lint
passes validation.