-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add version flag #136
Add version flag #136
Conversation
Hi @dkoshkin. Thanks for your PR. I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Pull Request Test Coverage Report for Build 218
💛 - Coveralls |
/ok-to-test |
@dkoshkin thanks for the PR. For the unit test, could you create a |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dkoshkin, leakingtapan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Is this a bug fix or adding new feature?
Fixes #21
What is this PR about? / Why do we need it?
This PR adds
--version
flag at the top level command.Running
aws-ebs-csi-driver --version
will pretty print the JSON, with the same format askubectl version
.This PR does not add support for printing the info in any other format.
What testing is done?
Locally built the image and tested:
I am not aware of a way to unit test when using
-ldflags
, if anyone has some pointers would be glad to add a unit test.