-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move test integration #153
Move test integration #153
Conversation
Hi @kschumy. Thanks for your PR. I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold As we discussed, we are introducing EC2 based integration tests. We will test this PR locally. |
e5c4aaa
to
dd7d262
Compare
@kschumy: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
edfca00
to
23db543
Compare
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add some README (maybe under tests/integration) about how to run the integration test locally and what are required for integration test to run, etc?
And lets squash the commit once all the changes are done
hack/test-integration.sh
Outdated
|
||
if ! [[ "$0" =~ hack/test-integration.sh ]]; then | ||
echo "must be run from repository root" | ||
exit 255 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we use 255 as exit code? Here is the list of special meaning of exit code: http://tldp.org/LDP/abs/html/exitcodes.html Maybe we can use 1 as general error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah let's use exit 127
for illegal command, instead.
/cc @kschumy
@gyuho: GitHub didn't allow me to request PR reviews from the following users: kschumy. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
hack/test-integration.sh
Outdated
fi | ||
|
||
go test -c ./tests/integration/... -o bin/integration.test && \ | ||
sudo -E bin/integration.test -ginkgo.v |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok let's instead do:
sudo -E bin/integration.test -test.v -ginkgo.v
871122f
to
036cffe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@leakingtapan was this what you wanted?
Looks like a good start |
feb3211
to
dc0140c
Compare
tests/integration/README.md
Outdated
#### Using `aws-ebs-csi-driver` | ||
|
||
```bash | ||
cd ${GOPATH}/src/github.com/aws/aws-k8s-tester |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since make test-integration now runs aws-k8s-tester automatically, I changed this to being about running aws-k8s-tester independently
tests/integration/README.md
Outdated
@@ -0,0 +1,33 @@ | |||
## Running Integration Tests with `aws-k8s-tester` | |||
|
|||
[`aws-k8s-tester`](https://github.com/aws/aws-k8s-tester) is an e2e test deployment interface for testing K8s clusters on AWS and is used in conjunction with `aws-ebs-csi-driver` for csi integration tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done!
Add some comments on the README for integ test. Could you squash all the changes into one commit after all the change? |
261aed7
to
9957ffd
Compare
/lgtm Defer to @leakingtapan. In the meantime, @kschumy will be adding a Prow job in upstream test-infra. Thanks! |
hack: create test-integration.sh Makefile: use aws-k8s-tester with test-integration tests/integration: create README
9957ffd
to
ccaa7a0
Compare
/lgtm thanks for picking up the latest! |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kschumy, leakingtapan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel @kschumy will look into ways to automate release version fetch, in the following PR. Thanks! |
Is this a bug fix or adding new feature?
Feature
What is this PR about? / Why do we need it?
make test-integration uses aws-k8s-tester
What testing is done?
Ran locally
@gyuho @leakingtapan