Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove vendor directory #198

Merged
merged 1 commit into from
Feb 9, 2019
Merged

Remove vendor directory #198

merged 1 commit into from
Feb 9, 2019

Conversation

leakingtapan
Copy link
Contributor

@leakingtapan leakingtapan commented Feb 1, 2019 •
edited
Loading

Fixes: #202

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 1, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leakingtapan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2019
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 1, 2019
@leakingtapan leakingtapan force-pushed the vendor branch 2 times, most recently from 10ccfaf to 9b199c8 Compare February 2, 2019 00:44
@leakingtapan
Copy link
Contributor Author

/test pull-aws-ebs-disk-csi-driver-verify

@leakingtapan leakingtapan reopened this Feb 8, 2019
@k8s-ci-robot k8s-ci-robot added the sig/auth Categorizes an issue or PR as relevant to SIG Auth. label Feb 8, 2019
@leakingtapan leakingtapan force-pushed the vendor branch 4 times, most recently from 6016aa4 to 5b6da02 Compare February 8, 2019 07:02
@coveralls
Copy link

coveralls commented Feb 8, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 431

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 64.433%
Totals Coverage Status
Change from base Build 427: 0.0%
Covered Lines: 779
Relevant Lines: 1209
💛 - Coveralls

@leakingtapan
Copy link
Contributor Author

There are some issue in aws-k8s-test, which we use for integration testing.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 8, 2019 •
edited
Loading

@leakingtapan: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-aws-ebs-disk-csi-driver-verify 9b199c8 link /test pull-aws-ebs-disk-csi-driver-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@leakingtapan
Copy link
Contributor Author

This should fix the issue aws/aws-k8s-tester#41

Remove vendor directory
f434cf3 
* Bump version for aws-k8s-test
* Turn on GO mod in integration test
@leakingtapan leakingtapan merged commit 30f0659 into kubernetes-sigs:master Feb 9, 2019
@leakingtapan leakingtapan deleted the vendor branch February 9, 2019 02:35
jsafrane pushed a commit to jsafrane/aws-ebs-csi-driver that referenced this pull request May 4, 2022
@openshift-merge-robot
Merge pull request kubernetes-sigs#198 from yselkowitz/bz2050173
96a9921 
Bug 2050173: Fix build on ARM after rebase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertinatto bertinatto Awaiting requested review from bertinatto

@d-nishi d-nishi Awaiting requested review from d-nishi

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leakingtapan @k8s-ci-robot @coveralls